[ResponseOps][Alerting] Hiding all features in a space causes rules to stop running#146188
Merged
doakalexi merged 12 commits intoelastic:mainfrom Dec 12, 2022
Merged
[ResponseOps][Alerting] Hiding all features in a space causes rules to stop running#146188doakalexi merged 12 commits intoelastic:mainfrom
doakalexi merged 12 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
I repeated my verification steps from here #145372 (comment) and I can see that my no-rule-access user can't see any rules with the find API and also that the rule continues running even when all features in a space are turned off. |
Contributor
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing exports
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #144638
Summary
Removes logic that prevents rules from running when all features in a space are disabled.
Checklist
To verify