Skip to content

[ResponseOps][Alerting] Hiding all features in a space causes rules to stop running#146188

Merged
doakalexi merged 12 commits intoelastic:mainfrom
doakalexi:alerting/loading-rule
Dec 12, 2022
Merged

[ResponseOps][Alerting] Hiding all features in a space causes rules to stop running#146188
doakalexi merged 12 commits intoelastic:mainfrom
doakalexi:alerting/loading-rule

Conversation

@doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Nov 23, 2022

Resolves #144638

Summary

Removes logic that prevents rules from running when all features in a space are disabled.

Checklist

To verify

  • Create an alerting rule
  • Go to the spaces page, and disable all features in the space
  • Look at your terminal to see the alerting rule still running and no errors

@doakalexi doakalexi changed the title Updating to load the rule once [ResponseOps][Alerting] Hiding all features in a space causes rules to stop running Nov 23, 2022
@doakalexi doakalexi added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Nov 23, 2022
@doakalexi
Copy link
Contributor Author

@elasticmachine merge upstream

@doakalexi doakalexi marked this pull request as ready for review December 5, 2022 20:43
@doakalexi doakalexi requested a review from a team as a code owner December 5, 2022 20:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor

ymao1 commented Dec 7, 2022

I repeated my verification steps from here #145372 (comment) and I can see that my no-rule-access user can't see any rules with the find API and also that the rule continues running even when all features in a space are turned off.

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Alerts timeline Add a non-empty property to default timeline

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
alerting 34 35 +1
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit 4f1552e into elastic:main Dec 12, 2022
@kibanamachine kibanamachine added v8.7.0 backport:skip This PR does not require backporting labels Dec 12, 2022
@doakalexi doakalexi deleted the alerting/loading-rule branch December 13, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiding all features in a space causes rules to stop running

6 participants