Skip to content

Upgrade node-sass to 8.0.0#145355

Merged
jbudz merged 11 commits intoelastic:mainfrom
jbudz:node-sass-8
Dec 8, 2022
Merged

Upgrade node-sass to 8.0.0#145355
jbudz merged 11 commits intoelastic:mainfrom
jbudz:node-sass-8

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Nov 16, 2022 •
edited by kibanamachine
Loading

@jbudz jbudz added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Nov 16, 2022
@jbudz jbudz marked this pull request as ready for review November 16, 2022 15:05
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 16, 2022

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz enabled auto-merge (squash) December 7, 2022 21:53
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 7, 2022

@elasticmachine merge upstream

@jbudz jbudz disabled auto-merge December 8, 2022 01:49
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Dec 8, 2022

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit d40e0f7 into elastic:main Dec 8, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 8, 2022

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
❌ 8.5 Backport failed because of merge conflicts
❌ 8.6 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 145355

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit to jbudz/kibana that referenced this pull request Dec 8, 2022
@jbudz @kibanamachine
Upgrade node-sass to 8.0.0 (elastic#145355)
99659b6 
This is needed for Node 18.

https://github.com/sass/node-sass/releases/tag/v8.0.0

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz jbudz mentioned this pull request Dec 8, 2022
Merged
@jbudz jbudz mentioned this pull request Dec 8, 2022
Merged
jbudz added a commit that referenced this pull request Dec 8, 2022
@jbudz @kibanamachine
[8.6] Upgrade node-sass to 8.0.0 (#145355) (#147279)
d8230ef 
#145355

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Dec 9, 2022
Merged
1 task
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 9, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 9, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 12, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine mentioned this pull request Dec 13, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 13, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 14, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

jbudz added a commit to jbudz/kibana that referenced this pull request Dec 14, 2022
@jbudz @kibanamachine
Upgrade node-sass to 8.0.0 (elastic#145355)
7671789 
This is needed for Node 18.

https://github.com/sass/node-sass/releases/tag/v8.0.0

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 15, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 15, 2022
jbudz added a commit that referenced this pull request Dec 15, 2022
@jbudz @kibanamachine
[7.17] Upgrade node-sass to 8.0.0 (#145355) (#147282)
db1ec0c 
#145355

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jbudz added a commit that referenced this pull request Dec 15, 2022
@jbudz
Revert "[7.17] Upgrade node-sass to 8.0.0 (#145355) (#147282)"
c8a06ae 
This reverts commit db1ec0c.
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 15, 2022 •
edited
Loading

Temporarily reverted 7.17 backport after https://buildkite.com/elastic/kibana-macos-bazel-cache/builds/15068 - I believe it's unrelated, but wanted to rule any changes out.

jbudz added a commit to jbudz/kibana that referenced this pull request Jan 3, 2023
@jbudz
[7.17] Upgrade node-sass to 8.0.0 (elastic#145355)
d031db0 
This reverts commit c8a06ae.
@jbudz jbudz mentioned this pull request Jan 3, 2023
Merged
jbudz added a commit that referenced this pull request Jan 3, 2023
@jbudz
[7.17] Upgrade node-sass to 8.0.0 (#145355) (#148299)
f9eb6b9 
#145355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

Assignees

No one assigned

Labels

backport:all-open Backport to all branches that could still receive a release backport pending release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.6.0 v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jbudz @elasticmachine @kibana-ci @kibanamachine @mistic