[fleet/language_clients] wrap route in suspense#145260
Merged
spalger merged 1 commit intoelastic:mainfrom Nov 15, 2022
Merged
Conversation
spalger
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
spalger
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
nchaulet
approved these changes
Nov 15, 2022
Member
nchaulet
left a comment
nchaulet
left a comment
There was a problem hiding this comment.
🚀 it did not work before that correct?
Contributor
Author
|
Correct, without this change this is what happens on the page: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #145166 we setup the language client docs pages to load async, but didn't add the suspense wrapper which is needed to load the async components. This adds that missing piece.