Skip to content

[Security Solution] Add Task Metric Collection to New Tasks #145181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDKurma merged 1 commit into from
Nov 14, 2022
Merged

[Security Solution] Add Task Metric Collection to New Tasks #145181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion x-pack/plugins/security_solution/server/lib/telemetry/tasks/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
*/

import type { Logger } from '@kbn/core/server';
import { TASK_METRICS_CHANNEL } from '../constants';
import type { ITelemetryEventsSender } from '../sender';
import type { TelemetryConfiguration } from '../types';
import type { ITelemetryReceiver } from '../receiver';
import type { TaskExecutionPeriod } from '../task';
import { artifactService } from '../artifact';
import { telemetryConfiguration } from '../configuration';
import { tlog } from '../helpers';
import { createTaskMetric, tlog } from '../helpers';

export function createTelemetryConfigurationTaskConfig() {
return {
Expand All @@ -28,6 +29,8 @@ export function createTelemetryConfigurationTaskConfig() {
sender: ITelemetryEventsSender,
taskExecutionPeriod: TaskExecutionPeriod
) => {
const startTime = Date.now();
const taskName = 'Security Solution Telemetry Configuration Task';
try {
const artifactName = 'telemetry-buffer-and-batch-sizes-v1';
const configArtifact = (await artifactService.getArtifact(
Expand All @@ -42,10 +45,16 @@ export function createTelemetryConfigurationTaskConfig() {
configArtifact.max_endpoint_telemetry_batch;
telemetryConfiguration.max_security_list_telemetry_batch =
configArtifact.max_security_list_telemetry_batch;
await sender.sendOnDemand(TASK_METRICS_CHANNEL, [
createTaskMetric(taskName, true, startTime),
]);
return 0;
} catch (err) {
tlog(logger, `Failed to set telemetry configuration due to ${err.message}`);
telemetryConfiguration.resetAllToDefault();
await sender.sendOnDemand(TASK_METRICS_CHANNEL, [
createTaskMetric(taskName, false, startTime, err.message),
]);
return 0;
}
},
Expand Down
11 changes: 10 additions & 1 deletion x-pack/plugins/security_solution/server/lib/telemetry/tasks/filterlists.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
*/

import type { Logger } from '@kbn/core/server';
import { TASK_METRICS_CHANNEL } from '../constants';
import type { ITelemetryEventsSender } from '../sender';
import type { TelemetryFilterListArtifact } from '../types';
import type { ITelemetryReceiver } from '../receiver';
import type { TaskExecutionPeriod } from '../task';
import { artifactService } from '../artifact';
import { filterList } from '../filterlists';
import { tlog } from '../helpers';
import { createTaskMetric, tlog } from '../helpers';

export function createTelemetryFilterListArtifactTaskConfig() {
return {
Expand All @@ -28,6 +29,8 @@ export function createTelemetryFilterListArtifactTaskConfig() {
sender: ITelemetryEventsSender,
taskExecutionPeriod: TaskExecutionPeriod
) => {
const startTime = Date.now();
const taskName = 'Security Solution Telemetry Filter List Artifact Task';
try {
const artifactName = 'telemetry-filterlists-v1';
const artifact = (await artifactService.getArtifact(
Expand All @@ -36,10 +39,16 @@ export function createTelemetryFilterListArtifactTaskConfig() {
filterList.endpointAlerts = artifact.endpoint_alerts;
filterList.exceptionLists = artifact.exception_lists;
filterList.prebuiltRulesAlerts = artifact.prebuilt_rules_alerts;
await sender.sendOnDemand(TASK_METRICS_CHANNEL, [
createTaskMetric(taskName, true, startTime),
]);
return 0;
} catch (err) {
tlog(logger, `Failed to set telemetry filterlist artifact due to ${err.message}`);
filterList.resetAllToDefault();
await sender.sendOnDemand(TASK_METRICS_CHANNEL, [
createTaskMetric(taskName, false, startTime, err.message),
]);
return 0;
}
},
Expand Down