[8.6][Session View] Fix hidden alert flyout in session view#145141
Merged
Omolola-Akinleye merged 2 commits intoelastic:mainfrom Nov 14, 2022
Merged
[8.6][Session View] Fix hidden alert flyout in session view#145141Omolola-Akinleye merged 2 commits intoelastic:mainfrom
Omolola-Akinleye merged 2 commits intoelastic:mainfrom
Conversation
Omolola-Akinleye
added
bug
Omolola-Akinleye
added
the
release_note:skip
| const loadDetailsPanel = useCallback( | ||
| (panelConfig?: TimelineExpandedDetailType) => { | ||
| if (panelConfig && scopedActions) { | ||
| if (isTimelineScope(scopeId)) { |
Contributor
There was a problem hiding this comment.
Thanks! Yea...this shouldn't be only scoped to timeline.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 15, 2022
* main: (65 commits) Migrate server-side `Root` and `Server` to packages (elastic#144990) [Discover] Handle no data views state for `esQuery` alert (elastic#145052) [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704) [api-docs] 2022-11-15 Daily api_docs build (elastic#145203) [Security solution] remove guided onboarding feature flag (elastic#144247) [DOCS] Automate final case APIs (elastic#145007) [Enterprise Search] Name and description flyout for connectors (elastic#143827) [Guided onboarding] Update header button logic (elastic#144634) [Lens] Multi metric partition charts (elastic#143966) [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947) [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181) [TriggersActionsUi] disable jest config in CI (elastic#145186) [TableListView] Enhance tag filtering (elastic#142108) [Cloud Posture] Compliance by CIS section table (elastic#145114) [8.6][Session View] Fix hidden alert flyout in session view (elastic#145141) [customIntegrations] async load all components (elastic#145166) Fix time for logs smoke tests in integration test (elastic#145130) [RAM] Update rule status (elastic#140882) Update babel (main) (elastic#145060) [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alert Flyout Detail panel doesn't show in session view
Summarize your PR. If it involves visual changes include a screenshot or gif.
When clicking on the expand icon in the process alert row or
View detailsin the Alert tab content, the Alert flyout doesn't show.Before the alerts flyout was showing in session view until
isTimelineScope()was added. We need to dispatch the toggle to the details panel even if the timeline is not in scope.