[7.x] Convert event log's duration from number to string in Kibana (keep as "long" in Elasticsearch)#144837
Conversation
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @mikecote |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ersin-erdal
left a comment
There was a problem hiding this comment.
Added a comment about changing duration, sequence and severity type mapping.
| sequence: ecsNumber(), | ||
| severity: ecsNumber(), | ||
| sequence: ecsStringOrNumber(), | ||
| severity: ecsStringOrNumber(), |
There was a problem hiding this comment.
Did you change these manually? I don't see any change on mappings.js
There was a problem hiding this comment.
With the change, the data type in Elasticsearch will remain the same long type (hence no change there), but I had to change the generation script and output files to indicate the accepted and returned value may be a string or a number (previously just number).
ersin-erdal
left a comment
There was a problem hiding this comment.
LGTM,
Tested locally and was able to see the duration field as string.
Fixes #143562.
Backport of #130819 to
7.x.Steps to verify
Create a rule that creates an alert consistently (ex: index threshold)
Let the rule run a few times
See event log now capturing long durations successfully