[ML] Adding cloud trial end date to ml info#144793
Merged
jgowdyelastic merged 8 commits intoelastic:mainfrom Nov 9, 2022
Merged
[ML] Adding cloud trial end date to ml info#144793jgowdyelastic merged 8 commits intoelastic:mainfrom
jgowdyelastic merged 8 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
darnautov
approved these changes
Nov 9, 2022
Contributor
darnautov
left a comment
There was a problem hiding this comment.
LGTM! Would be great to extend to the KibanaContextProvider with this info as well
Member
Author
Yes, that's a good idea. Outside of the scope of this PR, but I can add it in a follow up. |
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
isCloudTrialflag to ML's/api/ml/infoendpoint.If
xpack.cloud.trial_end_dateis set in the kibana config and it is greater than the current time, we can assume that we're currently in a could trial.If
xpack.cloud.trial_end_dateis not set,isCloudTrialis not added to the endpoint response. This is the same behaviour as thecloudIdproperty.Adds a
isCloudTrial()function to our server info util functions which can be used in conjunction with ourisCloud()function.To test, these cloud settings can be added to the kibana config: