[Guided onboarding] More API fixes#144729
Merged
yuliacech merged 3 commits intoelastic:mainfrom Nov 8, 2022
Merged
Conversation
yuliacech
added
release_note:skip
Contributor
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
alisonelizabeth
approved these changes
Nov 7, 2022
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Left one question in the code, but otherwise LGTM. Tested locally.
| ); | ||
| const currentState = this.guideState$.value; | ||
| if (!currentState && !this.isGuideStateLoading && !this.isGuideStateInitialized) { | ||
| this.isGuideStateLoading = true; |
Contributor
There was a problem hiding this comment.
Can you explain why this is needed here?
Contributor
Author
There was a problem hiding this comment.
Sure, I'll add a comment to the code
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic of the API service to prevent spamming the endpoint with too many requests, especially when there is no active guide. The solution is to introduce a variable for initialized state because otherwise we can't differentiate between a guide state that has not been fetched yet and a guide state that represents a new deployment with no active guides yet.