Skip to content

[packages/kbn-journeys] fix apm agent start/stop to track browser interactions only #144267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmlemeshko merged 1 commit into from
Nov 1, 2022
Merged

[packages/kbn-journeys] fix apm agent start/stop to track browser interactions only #144267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/kbn-journeys/journey/journey_ftr_harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export class JourneyFtrHarness {

private async onSetup() {
await Promise.all([
this.setupApm(),
this.setupBrowserAndPage(),
asyncForEach(this.journeyConfig.getEsArchives(), async (esArchive) => {
await this.esArchiver.load(esArchive);
Expand All @@ -127,6 +126,10 @@ export class JourneyFtrHarness {
await this.kibanaServer.importExport.load(kbnArchive);
}),
]);

// It is important that we start the APM transaction after we open the browser and all the test data is loaded
// so that the scalability data extractor can focus on just the APM data produced by Kibana running under test.
await this.setupApm();
}

private async tearDownBrowserAndPage() {
Expand Down Expand Up @@ -181,9 +184,12 @@ export class JourneyFtrHarness {
}

private async onTeardown() {
await this.tearDownBrowserAndPage();
// It is important that we complete the APM transaction after we close the browser and before we start
// unloading the test data so that the scalability data extractor can focus on just the APM data produced
// by Kibana running under test.
await this.teardownApm();
await Promise.all([
this.tearDownBrowserAndPage(),
this.teardownApm(),
asyncForEach(this.journeyConfig.getEsArchives(), async (esArchive) => {
await this.esArchiver.unload(esArchive);
}),
Expand Down