Skip to content

Comments

[Lens] Updates the UI copy for Random sampling#144265

Merged
KOTungseth merged 2 commits intoelastic:mainfrom
KOTungseth:lens/sampling-text
Nov 9, 2022
Merged

[Lens] Updates the UI copy for Random sampling#144265
KOTungseth merged 2 commits intoelastic:mainfrom
KOTungseth:lens/sampling-text

Conversation

@KOTungseth
Copy link
Contributor

Summary

Updates the Random sampling copy.

Original PR: #143929

@KOTungseth KOTungseth added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting ui-copy Review of UI copy with docs team is recommended v8.6.0 labels Oct 31, 2022
@KOTungseth KOTungseth requested a review from dej611 October 31, 2022 18:33
@KOTungseth KOTungseth self-assigned this Oct 31, 2022
@KOTungseth KOTungseth requested a review from a team as a code owner October 31, 2022 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :) LGTM!

@KOTungseth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -20.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

@KOTungseth KOTungseth merged commit 64c3c63 into elastic:main Nov 9, 2022
@KOTungseth KOTungseth deleted the lens/sampling-text branch November 9, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// ui-copy Review of UI copy with docs team is recommended v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants