[Maps] add in product help for layer group drag and drop instructions#144259
Merged
nreese merged 10 commits intoelastic:mainfrom Nov 2, 2022
Merged
[Maps] add in product help for layer group drag and drop instructions#144259nreese merged 10 commits intoelastic:mainfrom
nreese merged 10 commits intoelastic:mainfrom
Conversation
nreese
added
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
|
Here's a suggestion: Drag layers in and out of the group
Question: Is it clear to users that they populate the group in the Layers list? Or should we add that wording in the write-up above? If you just was want a simple feature announcement: Drag layers in and out of the group in the Layers list. |
Contributor
Author
|
@elasticmachine merge upstream |
gchaps
reviewed
Nov 2, 2022
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
gchaps
reviewed
Nov 2, 2022
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
gchaps
reviewed
Nov 2, 2022
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
gchaps
reviewed
Nov 2, 2022
| <> | ||
| <EuiCallOut | ||
| title={i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupCalloutTitle', { | ||
| defaultMessage: 'Use drag and drop to populate layer group', |
Contributor
There was a problem hiding this comment.
What do you think about "Drag layers in and out of the group" for the title?
Contributor
Author
There was a problem hiding this comment.
yes, lets use that title.
gchaps
approved these changes
Nov 2, 2022
Contributor
gchaps
left a comment
gchaps
left a comment
There was a problem hiding this comment.
LGTM with a few minor comments
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
sophiec20
added
Feature:Maps
and removed
Team:Geo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #142528
Drag and drop features can be hard to discover. This PR adds some in product help that describes how to use drag and drop to add and remove layers from a layer group.