Skip to content

[Fleet] Add the @custom pipeline only to the main datastream ingest pipeline#144150

Merged
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:fix-custom-pipeline-only-main-pipelines
Oct 31, 2022
Merged

[Fleet] Add the @custom pipeline only to the main datastream ingest pipeline#144150
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:fix-custom-pipeline-only-main-pipelines

Conversation

@nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 27, 2022

Description

Resolve elastic/integrations#4510

Some integration use multiple pipeline for a datastream and then conditionaly apply them in a main pipeline, we are currently injecting the @custom pipeline in all the pipeline causing the @custom pipeline to be called multiple times

That PR fix that by adding the @custom pipeline only to the main pipeline and not to the sub ones.

Test

  • This is covered by a unit test

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet self-assigned this Oct 28, 2022
@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0 labels Oct 28, 2022
@nchaulet nchaulet marked this pull request as ready for review October 28, 2022 18:06
@nchaulet nchaulet requested a review from a team as a code owner October 28, 2022 18:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Oct 28, 2022
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet nchaulet enabled auto-merge (squash) October 31, 2022 13:02
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 499e800 into elastic:main Oct 31, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 31, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
* main:
  [Fleet] Add the @Custom pipeline only to the main datastream ingest pipelines (elastic#144150)
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
@nchaulet nchaulet deleted the fix-custom-pipeline-only-main-pipelines branch November 23, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@Custom Pipeline Behaviour

5 participants