[APM] Normalize time range for apm-per-service telemetry#144126
Closed
basepi wants to merge 1 commit intoelastic:mainfrom
Closed
[APM] Normalize time range for apm-per-service telemetry#144126basepi wants to merge 1 commit intoelastic:mainfrom
basepi wants to merge 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
Member
|
could this try first for 1d and back off to 1h in case of timeout? |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
Contributor
Author
Good idea! Since we're using proper timeouts, running the queries twice shouldn't be much of a problem. I'll move this to draft and make a note in the description, I don't have time to do this properly at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After discussions on #144061 I think we should probably normalize
apm-per-serviceto also use therange1dfilter instead ofnow-1h.Edit: At @graphaelli's recommendation I'm going to have it do 1d, check the timeout, and if it timed out do the 1h version. I'll re-request review at that point.
For maintainers