Skip to content

[APM] Normalize time range for apm-per-service telemetry#144126

Closed
basepi wants to merge 1 commit intoelastic:mainfrom
basepi:apm_per_service_telemetry
Closed

[APM] Normalize time range for apm-per-service telemetry#144126
basepi wants to merge 1 commit intoelastic:mainfrom
basepi:apm_per_service_telemetry

Conversation

@basepi
Copy link
Contributor

@basepi basepi commented Oct 27, 2022

Summary

After discussions on #144061 I think we should probably normalize apm-per-service to also use the range1d filter instead of now-1h.

Edit: At @graphaelli's recommendation I'm going to have it do 1d, check the timeout, and if it timed out do the 1h version. I'll re-request review at that point.

For maintainers

@basepi basepi added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Oct 27, 2022
@basepi basepi requested a review from a team October 27, 2022 18:42
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@basepi basepi changed the title Normalize time range for apm-per-service telemetry [APM] Normalize time range for apm-per-service telemetry Oct 27, 2022
@graphaelli
Copy link
Member

could this try first for 1d and back off to 1h in case of timeout?

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@basepi
Copy link
Contributor Author

basepi commented Oct 27, 2022

could this try first for 1d and back off to 1h in case of timeout?

Good idea! Since we're using proper timeouts, running the queries twice shouldn't be much of a problem. I'll move this to draft and make a note in the description, I don't have time to do this properly at the moment.

@basepi basepi marked this pull request as draft October 27, 2022 20:16
@basepi basepi closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants