[x-pack/performance] use es/kbn archives with sample data, load dashboard w/out map#144100
Conversation
|
Pinging @elastic/kibana-operations (Team:Operations) |
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Looks good!
I would add the
- standalone map test
- waitForChrome
What do you say?
| kbnArchives: ['x-pack/performance/kbn_archives/ecommerce_no_map_dashboard'], | ||
| }).step('Go to Ecommerce Dashboard', async ({ page, kbnUrl }) => { | ||
| await page.goto(kbnUrl.get(`/app/dashboards#/view/722b74f0-b882-11e8-a6d9-e546fe2bba5f`)); | ||
| await waitForVisualizations(page, 12); |
There was a problem hiding this comment.
Can you also navigate to the dashboard via the home page?
I worry if going to the dashboard directly puts unnecessary load on the server (loading static assets)
There was a problem hiding this comment.
Done a6d7cb9a29fd776b99d563931b8a817642949969
map only test
…rneys/remove-map-viz-from-dashboards
Cherry-picked from your branch 👍 |
dmlemeshko
added
the
release_note:skip
There was a problem hiding this comment.
You don't really need to wait for chrome if you're navigating to the dashboard.
It's only useful if you're using goto directly like you did before
There was a problem hiding this comment.
I will remove it then.
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Looks good
I added one comment
|
Pinging @elastic/apm-ui (Team:APM) |
dmlemeshko
force-pushed
the
performance-journeys/remove-map-viz-from-dashboards
branch
from
0c8caad to
c7ac3d2
Compare
…rneys/remove-map-viz-from-dashboards
dmlemeshko
force-pushed
the
performance-journeys/remove-map-viz-from-dashboards
branch
from
b8377a2 to
0423f3c
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
dmlemeshko
deleted the
performance-journeys/remove-map-viz-from-dashboards
branch
6 participants
Summary
We did few experiments with @lizozom and we can see dashboard loading is way faster and more consistent when it does not contain map visualisation.
We see WebGL errors while loading dashboard with maps and we decided to test maps separately. It also feels right to cut number of steps to simply load the dashboard and wait for its render completion.
PR is still using subset of sample data (representing 7-8 days) and saved objects of dashboards w/out maps.