[Security Solution][Endpoint][Response Actions] Show download link for get-file action on response actions history#144094
Merged
ashokaditya merged 9 commits intoOct 31, 2022
Conversation
Show download link for successful get-file actions on action history fixes elastic/security-team/issues/5076
ashokaditya
added
v8.6.0
release_note:skip
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
| privileges: endpointPrivileges, | ||
| }, | ||
| exampleUsage: 'get-file path "/full/path/to/file.txt" --comment "Possible malware"', | ||
| exampleUsage: 'get-file --path "/full/path/to/file.txt" --comment "Possible malware"', |
| /> | ||
| </EuiText> | ||
| </> | ||
| <EuiFlexGroup alignItems="center" gutterSize="none"> |
Contributor
There was a problem hiding this comment.
can you add data-test-subj={dataTestSubj} here so that the entire component gets a test subject?
review changes (@paul-tavares)
ashokaditya
force-pushed
the
feat/olm-get-file-download-link-action-history-5076
branch
from
f926f7c to
72aed7e
Compare
review change (@paul-tavares)
ashokaditya
force-pushed
the
feat/olm-get-file-download-link-action-history-5076
branch
from
b85bc15 to
e67bf36
Compare
dasansol92
reviewed
Oct 28, 2022
Contributor
dasansol92
left a comment
dasansol92
left a comment
There was a problem hiding this comment.
Looking good! Left a comment, let me know what do you think about it!
review change (@dasansol92)
dasansol92
approved these changes
Oct 28, 2022
Contributor
dasansol92
left a comment
dasansol92
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM!
gergoabraham
approved these changes
Oct 28, 2022
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
only one small suggestion, looks great 🎉
review suggestion (@gergoabraham)
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
ashokaditya
deleted the
feat/olm-get-file-download-link-action-history-5076
branch
ashokaditya
added
release_note:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shows a download link for
get-fileaction on success for users with file operation permission/privilege (RBAC). The link is not shown when the user doesn't have that permission.To verify. Create a role without file operations and log in with a user that has only this custom role assigned. You should not see the download link on successful
get-fileactions.with file operation permission
without file operation permission
Checklist
Delete any items that are not applicable to this PR.