[Detection Engine] Add guided onboarding rule#144065
Merged
xcrzx merged 2 commits intoelastic:mainfrom Oct 27, 2022
Merged
Conversation
brokensound77
added
release_note:skip
brokensound77
commented
Oct 26, 2022
| @@ -10,713 +10,713 @@ | |||
| // - detection-rules repo using CLI command build-release | |||
| // Do not hand edit. Run script/command to regenerate package information instead | |||
|
|
|||
| import rule1 from './credential_access_access_to_browser_credentials_procargs.json'; | |||
Contributor
Author
There was a problem hiding this comment.
I noticed that the scripts/regen_prepackage_rules_index.sh orders the import by filename, whereas the detection-rules Package orders by rule name, which explains the mass change. It should have no impact, but we will see it revert to the name ordering on the next package update.
w0rk3r
approved these changes
Oct 26, 2022
terrancedejesus
approved these changes
Oct 26, 2022
Contributor
terrancedejesus
left a comment
terrancedejesus
left a comment
There was a problem hiding this comment.
Changes seem fine. My question is more towards the rule updates.
- If a client updates their existing stack to 8.5.0, this rule should load from file system but will CDN package overwrite and thus this rule will not exist? -> 8.3.2 package
- If client does not update and are on, say version 8.3.0 this rule does not exist in file system nor CDN?
xcrzx
approved these changes
Oct 27, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds guided onboarding detection rule
Checklist
Delete any items that are not applicable to this PR.
Screenshot