some updates to visualize loader

[ppisljar]

• visualize loader now returns a promise, which is resolved when visualize is done rendering with a handler that has a destroy method (which cleans up the visualize scope)
• visualize loader stops the vis:ready event propagation
• visualize emits vis:ready on its scope (instead of broadcast on rootscope)
• filter_manager add method was broken down in add and generate
• filter_manager was added to vis.api

filter_handler generate method comes very handy for adding new filters, check https://docs.google.com/document/d/1U7mZuGOpLwFWrb6zWf62k57hA1MUXL0PFRYW8EdrTjQ/edit# Embedding a saved object paragraph

[thomasneirynck]

@rashidkpc made the comment that Kibana-Canvas doesn't have access to the Private-module loader

Maybe we can work-around that on our end, by making the module import itself. Stripping this from angular is not necessary imo, it would not be worth the effort.

I think we have a couple of ways of bootstrapping Private. I made a small suggestion here:

import $ from 'jquery';
import uiRoutes from 'ui/routes';

function VisualizeLoaderProvider($compile, $rootScope, savedVisualizations) {
....
  return {
    embedVisualizationWithId: async(el, savedVisualizationId, params) => {
      return new Promise((resolve) => {
        savedVisualizations.get(savedVisualizationId).then(savedObj => {
          const element = renderVis(el, savedObj, params);
          resolve(element);
        });
      });
    },
    embedVisualizationWithSavedObject: (el, savedObj, params) => {
      return renderVis(el, savedObj, params);
    }
  };
}


let visualizeLoader = null;
let pendingPromise = null;
let pendingResolve = null;
uiRoutes.addSetupWork(function (Private) {
  visualizeLoader = Private(VisualizeLoaderProvider);
  if (pendingResolve) {
    pendingResolve(visualizeLoader);
  }
});

export async function getVisualizeLoader() {
  if (!pendingResolve) {
    pendingPromise = new Promise((resolve)=> {
      pendingResolve = resolve;
    });
  }
  return pendingPromise;
};

and then from the client, you can use it as

import {getVisualizeLoader} from 'ui/visualize/loader`;

getVisualizeLoader()
.then(visualizeLoader) => {
    visualizeLoader.embedVisualizationWithId(...);
});

[ppisljar]

Every kibana plugin has access to the Private module loader ...

[rashidkpc]

We purposefully designed the Canvas element plugin API to enable rendering outside of the Kibana architecture.

While in theory we could use Redux to funnel Private down to a React component that exposes a DOM node as ref it would have the effect of breaking the exportability of Canvas elements which we don't want to do.

[thomasneirynck]

failing on license error. needs rebase to include 2a14502.

[thomasneirynck]

I tested this with the a test-app, using both means of loading the visualizeLoader.

Works well IMO. Thx!

tagcloud and regionmap do give errors when filtering, but this is likely more a problem with how they do filtering. we can fix those separately.

[thomasneirynck]

@rashidkpc

This proposes an additional way of loading the visualizationLoader. You will be able to call a function called getVisualizeLoader that will return the module. You can then use it as-is. This takes care of the wrapping for you, and you will not have to propagate the Private-boostrapper inside your Canvas code. Once this is merged, it be helpful if you could try it out in Canvas, and see if you run into problems using it.

[nreese]

LGTM

[ppisljar]

backport
6.x: edf4a54
6.0: 142db97