[Security Solution][Endpoint] Adds RBAC API checks for event filters#144009
Merged
dasansol92 merged 2 commits intoelastic:mainfrom Oct 27, 2022
Merged
Conversation
dasansol92
added
release_note:skip
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
dasansol92
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
gergoabraham
approved these changes
Oct 27, 2022
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
Looks good! 🎉
I've tested it, and was able to check it with reading the event filter list, receiving 403 when privilege is taken.
gergoabraham
requested changes
Oct 27, 2022
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
I just checked it with creating a new filter, and was able with read permission - please don't merge yet, I need to double check
gergoabraham
approved these changes
Oct 27, 2022
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
My mistake, everything works great. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For maintainers