[ML] Explain Log Rate Spikes: Limit fields for frequent_items agg.#143974
Merged
walterra merged 4 commits intoelastic:mainfrom Oct 27, 2022
Merged
Conversation
walterra
added
:ml
backport:skip
walterra
requested review from
alvarezmelissa87,
jgowdyelastic,
peteharverson and
qn895
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
release_note:skip
qn895
reviewed
Oct 26, 2022
| return p; | ||
| }, []); | ||
|
|
||
| // TODO add query params |
qn895
approved these changes
Oct 26, 2022
Member
|
Code LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @walterra |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #142568.
Limits the fields we pass on to the
frequent_itemsaggregation to 15. This is a trade off between speed and quality of the grouping result. The amount of fields we pass on to the agg grow the time it takes to get frequent items more than linearly and we risk timeouts with more fields.Checklist