[Guided onboarding] Add a config for test guide#143973
[Guided onboarding] Add a config for test guide#143973yuliacech merged 8 commits intoelastic:mainfrom
Conversation
…mple plugin to use it instead of search
alisonelizabeth
added
release_note:skip
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
Thanks for working on this @yuliacech! I left a few comments on the PR that I'd like to see addressed before merging, but I'm going to go ahead and approve to not block you.
Also, I noticed for the last step that the "Continue using Elastic" button shows before the "Mark done" button is clicked. I think this might be a bug. Do you mind taking a look and open up a separate issue if so? Thanks!
src/plugins/guided_onboarding/public/constants/guides_config/test_guide.ts
Outdated
Show resolved
Hide resolved
| descriptionList: [ | ||
| `This step is directly completed by clicking the button that uses the API function 'completeGuideStep`, | ||
| 'Navigate to /guidedOnboardingExample/stepOne to complete the step.', | ||
| 'Vivamus pretium, elit dictum lacinia aliquet, libero nibh dictum enim, a rhoncus leo magna in sapien.', |
There was a problem hiding this comment.
Do you want to delete this filler text?
| descriptionList: [ | ||
| 'This step is set to ready_to_complete on page navigation.', | ||
| 'After that click the popover on the guide button in the header and mark the step done', | ||
| 'Vivamus pretium, elit dictum lacinia aliquet, libero nibh dictum enim, a rhoncus leo magna in sapien.', |
There was a problem hiding this comment.
Do you want to delete this filler text?
| id="guidedOnboardingExample.guidesSelection.stepTwo.explanation1" | ||
| defaultMessage="The code on this page is listening to the guided setup state using an Observable subscription. If the state is set to | ||
| Search guide, step Browse documents, a EUI tour will be displayed, pointing to the button below." | ||
| Search guide, step Browse documents, a EUI tour will be displayed." |
There was a problem hiding this comment.
I think this text should be deleted
| content={ | ||
| <EuiText> | ||
| <p>Click this button to complete step 2.</p> | ||
| <p>The tour step is displayed when Test guide, step 2 is active.</p> |
There was a problem hiding this comment.
Can you delete the tour? I don't think it's necessary for step 2, but flashes briefly.
…est_guide.ts Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
|
Hey @mibragimov, adding you to the conversation in this PR so that you can get a notification when it's merged. You'll probably get some merge conflicts for your api integration tests work. Sorry about that! |
|
Thanks for the heads up @yuliacech! No problem about the merge conflicts, I'll resolve them. |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
6 participants
Summary
Fixes #143392
This PR adds a 4th guide config that is used for unit tests. This test guide can also be used for e2e tests (#138568). In follow up work we want to also add storybook for UI components and mocks for other guides for testing.