Skip to content

[Files] Fix image loading state #143970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jloleysens merged 3 commits into from
Oct 28, 2022
Merged

[Files] Fix image loading state #143970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dbe4e1
fix loading state
jloleysens Oct 25, 2022
e21f493
Merge branch 'main' into files-image-fix-loading-state
jloleysens Oct 27, 2022
d62b657
Merge branch 'main' into files-image-fix-loading-state
kibanamachine Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions x-pack/plugins/files/public/components/image/components/img.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,24 @@ import { sizes } from '../styles';

export interface Props extends ImgHTMLAttributes<HTMLImageElement> {
size?: EuiImageSize;
hidden: boolean;
observerRef: (el: null | HTMLImageElement) => void;
}

export const Img = React.forwardRef<HTMLImageElement, Props>(
({ observerRef, src, size, ...rest }, ref) => {
({ observerRef, src, size, hidden, ...rest }, ref) => {
const { euiTheme } = useEuiTheme();
const styles = [
css`
transition: opacity ${euiTheme.animation.extraFast};
`,
!src
hidden
? css`
visibility: hidden;
`
: undefined,
!src
? css`
position: absolute; // ensure that empty img tag occupies full container
top: 0;
right: 0;
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/files/public/components/image/image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const Image = React.forwardRef<HTMLImageElement, Props>(
size={size}
src={isVisible ? src : undefined}
alt={alt}
hidden={!isLoaded}
onLoad={(ev) => {
setIsLoaded(true);
onLoad?.(ev);
Expand Down