Skip to content

[Maps] highlight combine layer background when creating layer group#143909

Merged
nreese merged 4 commits intoelastic:mainfrom
nreese:layer_group_combine_color
Oct 26, 2022
Merged

[Maps] highlight combine layer background when creating layer group#143909
nreese merged 4 commits intoelastic:mainfrom
nreese:layer_group_combine_color

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Oct 24, 2022

Follow up to #142528

Screen Shot 2022-10-24 at 3 07 38 PM

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.6.0 Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Oct 24, 2022
@nreese nreese requested review from mdefazio and nickpeihl October 24, 2022 21:09
Copy link
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tested in chrome and code review

@nreese nreese force-pushed the layer_group_combine_color branch from 5205f39 to b71b025 Compare October 25, 2022 18:32
@nreese nreese marked this pull request as ready for review October 26, 2022 02:00
@nreese nreese requested review from a team as code owners October 26, 2022 02:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for doing this. Looks and works great.

@nreese
Copy link
Contributor Author

nreese commented Oct 26, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +467.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit cf8e6a7 into elastic:main Oct 26, 2022
@sophiec20 sophiec20 added Feature:Maps and removed Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants