Skip to content

Screenshotting Example - adding content-type#143800

Merged
kc13greiner merged 2 commits intoelastic:mainfrom
kc13greiner:feature/issue_671
Oct 27, 2022
Merged

Screenshotting Example - adding content-type#143800
kc13greiner merged 2 commits intoelastic:mainfrom
kc13greiner:feature/issue_671

Conversation

@kc13greiner
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner commented Oct 20, 2022 •
edited by kibanamachine
Loading

Summary

Adding content-type to Screenshotting Example plugin

@kc13greiner kc13greiner added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release v8.6.0 labels Oct 20, 2022
@jeramysoucy jeramysoucy marked this pull request as ready for review October 24, 2022 14:25
@jeramysoucy jeramysoucy requested review from a team as code owners October 24, 2022 14:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 24, 2022

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 25, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kc13greiner kc13greiner merged commit bbbf9f8 into elastic:main Oct 27, 2022
@kc13greiner kc13greiner deleted the feature/issue_671 branch October 27, 2022 12:52
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 27, 2022
@kc13greiner @legrego
Adding content type (elastic#143800)
eaab981 
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
(cherry picked from commit bbbf9f8)
@kibanamachine kibanamachine mentioned this pull request Oct 27, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 27, 2022

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 143800

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 27, 2022
@kibanamachine @kc13greiner
Adding content type (#143800) (#144102)
deaf232 
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
(cherry picked from commit bbbf9f8)

Co-authored-by: Kurt <kc13greiner@users.noreply.github.com>
@mistic mistic added v8.5.1 and removed v8.5.0 labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

@dokmic dokmic dokmic approved these changes

Assignees

No one assigned

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.5.1 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kc13greiner @elasticmachine @kibana-ci @kibanamachine @tsullivan @dokmic @mistic @legrego