[Lens][Unified Field list] Add functional tests to fields lists and summary popover by dej611 · Pull Request #143747 · elastic/kibana

dej611 · 2022-10-20T13:24:42Z

Summary

This PR adds some functional tests for Lens fields list and adds some extra data-test-subject props to component to make them testable.

The following scenarios have been covered:

Check availability and empty fields groups
Check popup stats for field types
- check for Top values charts
  - check for values + other label
- check for histogram
- check for unsupported fields (geo_point)
- check for runtime fields (number + keyword)
Define a filter + check how popup stats are affected
Define a filter to exclude all fields + check how popup stats are affected
if dataView has a timeField check how fields list changes on date change

All checks are performed for regular dataView (with timeField), for ad-hoc (with time-field) and an ad-hoc (without time-field).

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

flash1293

Added some possible extensions to cover a few cases more that could become problematic

x-pack/test/functional/apps/lens/group1/fields_list.ts

jughosta

Thanks for adding more tests! 👍

jughosta · 2022-10-26T09:10:28Z

src/plugins/unified_field_list/public/components/field_stats/field_stats.tsx

              defaultMessage: 'Top values',
            }),
            id: 'topValues',
+            'data-test-subj': `${dataTestSubject}-topValues`,


Suggested change

'data-test-subj': `${dataTestSubject}-topValues`,

'data-test-subj': `${dataTestSubject}-buttonGroup-topValuesButton`,

jughosta · 2022-10-26T09:10:54Z

src/plugins/unified_field_list/public/components/field_stats/field_stats.tsx

              defaultMessage: 'Distribution',
            }),
            id: 'histogram',
+            'data-test-subj': `${dataTestSubject}-distribution`,


Suggested change

'data-test-subj': `${dataTestSubject}-distribution`,

'data-test-subj': `${dataTestSubject}-buttonGroup-distributionButton`,

jughosta · 2022-10-26T09:12:20Z

x-pack/plugins/lens/public/datasources/form_based/field_item.tsx

-                      })}
-                </EuiText>
-              </>
+              <EuiText size="s" data-test-subj="lnsFieldListPanel-missingContent">


Suggested change

<EuiText size="s" data-test-subj="lnsFieldListPanel-missingContent">

<EuiText size="s" data-test-subj="lnsFieldListPanel-missingFieldStats">

jughosta · 2022-10-26T09:12:31Z

x-pack/plugins/lens/public/datasources/form_based/field_item.tsx

+          }
+          if (!params.supported) {
+            return (
+              <EuiText data-test-subj="lnsFieldListPanel-missingContent">{params.element}</EuiText>


Suggested change

<EuiText data-test-subj="lnsFieldListPanel-missingContent">{params.element}</EuiText>

<EuiText data-test-subj="lnsFieldListPanel-missingFieldStats">{params.element}</EuiText>

jughosta · 2022-10-26T09:17:59Z

src/plugins/unified_field_list/public/components/field_stats/field_stats.tsx

  overrideMissingContent?: (params: {
    element: JSX.Element;
    noDataFound?: boolean;
+    supported?: boolean;


We could also merge noDataFound?: boolean; and supported?: boolean; into a single reason?: 'no-data' | 'unsupported' prop.

…8724

kibana-ci · 2022-10-26T14:53:44Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9057915

Failed CI Steps

FTR Configs #44

Test Failures

[job] [logs] FTR Configs #44 / APM API tests basic no data Storage details when data is loaded returns correct stats for processor events

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.3MB	1.3MB	+262.0B
`unifiedFieldList`	55.1KB	55.2KB	+115.0B
total			+377.0B

History

💔 Build #82779 failed ef89830
💚 Build #82733 succeeded 01e1f1f
💚 Build #82069 succeeded c675ab8
💛 Build #81770 was flaky dd7600c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mbondyra

LGTM 👌🏼 did you managed to run flaky test runner x times to make sure it doesn't introduce flakiness? 🙏🏼

dej611 · 2022-10-27T12:57:45Z

@mbondyra waiting for the 100 green checks: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1470#_

dej611 added 3 commits October 20, 2022 15:21

♻️ Add testId handlers

394ae92

✅ Add functional tests

5d13f06

Merge remote-tracking branch 'upstream/main' into tests/138724

dd7600c

dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.6.0 labels Oct 20, 2022

dej611 requested a review from a team as a code owner October 20, 2022 13:24

flash1293 reviewed Oct 20, 2022

View reviewed changes

x-pack/test/functional/apps/lens/group1/fields_list.ts Outdated Show resolved Hide resolved

x-pack/test/functional/apps/lens/group1/fields_list.ts Show resolved Hide resolved

x-pack/test/functional/apps/lens/group1/fields_list.ts Outdated Show resolved Hide resolved

dej611 and others added 7 commits October 20, 2022 18:55

Merge remote-tracking branch 'upstream/main' into tests/138724

3628752

Merge remote-tracking branch 'upstream/main' into tests/138724

d1ba1f1

💄 Wrap unsupported messages with testId

ea021d6

🔧 Enable creation of dataViews without timefield

54d11bc

✅ Extends tests for other dataview types + runtime fields

9a004c5

✅ Add more checks on top values charts

c675ab8

Merge branch 'main' into tests/138724

01e1f1f

dej611 requested a review from a team as a code owner October 26, 2022 09:01

jughosta approved these changes Oct 26, 2022

View reviewed changes

dej611 and others added 4 commits October 26, 2022 13:17

👌 Integrated feedback

5f235c1

Merge branch 'main' into tests/138724

ef89830

🐛 Fix testIds and added some logging

d4d0593

Merge branch 'tests/138724' of github.com:dej611/kibana into tests/13…

9057915

…8724

mbondyra approved these changes Oct 27, 2022

View reviewed changes

dej611 merged commit 2efad9d into elastic:main Oct 27, 2022

kibanamachine added the backport:skip This PR does not require backporting label Oct 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens][Unified Field list] Add functional tests to fields lists and summary popover#143747

[Lens][Unified Field list] Add functional tests to fields lists and summary popover#143747
dej611 merged 14 commits intoelastic:mainfrom
dej611:tests/138724

dej611 commented Oct 20, 2022 •

edited

Loading

Uh oh!

flash1293 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jughosta left a comment

Uh oh!

jughosta Oct 26, 2022

Uh oh!

jughosta Oct 26, 2022

Uh oh!

jughosta Oct 26, 2022

Uh oh!

jughosta Oct 26, 2022

Uh oh!

jughosta Oct 26, 2022

Uh oh!

kibana-ci commented Oct 26, 2022

Uh oh!

mbondyra left a comment

Uh oh!

dej611 commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	'data-test-subj': `${dataTestSubject}-topValues`,
	'data-test-subj': `${dataTestSubject}-buttonGroup-topValuesButton`,

	'data-test-subj': `${dataTestSubject}-distribution`,
	'data-test-subj': `${dataTestSubject}-buttonGroup-distributionButton`,

	<EuiText size="s" data-test-subj="lnsFieldListPanel-missingContent">
	<EuiText size="s" data-test-subj="lnsFieldListPanel-missingFieldStats">

	<EuiText data-test-subj="lnsFieldListPanel-missingContent">{params.element}</EuiText>
	<EuiText data-test-subj="lnsFieldListPanel-missingFieldStats">{params.element}</EuiText>

Conversation

dej611 commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

jughosta Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Oct 26, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

mbondyra left a comment

Choose a reason for hiding this comment

Uh oh!

dej611 commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dej611 commented Oct 20, 2022 •

edited

Loading