[ML] Display link to create data view from error cases in data frame analytics results pages by alvarezmelissa87 · Pull Request #143596 · elastic/kibana

alvarezmelissa87 · 2022-10-18T21:05:59Z

Summary

Fixes #141919

Classification/Regression:

Outlier detection:

Cloning:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2022-10-18T21:09:15Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Tested and LGTM

qn895 · 2022-10-19T17:30:43Z

...alytics/pages/analytics_exploration/components/index_pattern_prompt/index_pattern_prompt.tsx

        <FormattedMessage
          id="xpack.ml.dataframe.analytics.dataViewPromptMessage"
-          defaultMessage="No data view exists for index {destIndex}. "
+          defaultMessage="No data view exists for index{destIndex}. "


Is there supposed to be a space in between for index{destIndex}

I'm assuming it's like this for when destIndex is undefined. What about when destIndex is defined? It would read "No data view exists for indexmy-index-name. "

Good catch! Updated in 7e8031b

qn895 · 2022-10-19T17:33:49Z

...ata_frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx

+                <FormattedMessage
+                  id="xpack.ml.dataframe.analyticsList.noSourceDataViewForClone"
+                  defaultMessage="Unable to clone the analytics job. No data view exists for index {dataView}."
+                  values={{ dataView: sourceIndex }}


Super duper nit: The variable name dataView in this message is a bit confusing. Suggestion to rename variable to something like No data view exists for index {sourceIndex}.

Updated in 7e8031b

qn895 · 2022-10-19T17:35:21Z

...ata_frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx

+                            <FormattedMessage
+                              id="xpack.ml.dataframe.analytics.cloneAction.dataViewPromptLinkText"
+                              defaultMessage="Create a data view for {dataView}"
+                              values={{ dataView: sourceIndex }}


Super duper nit: Similarly, the variable name dataView in this message is a bit confusing as the data view has not been created yet. Suggestion to rename variable to something like Create a data view for {sourceIndex}.

Updated in 7e8031b

qn895 · 2022-10-19T17:43:01Z

...analytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx

    jobConfig?.analyzed_fields?.excludes,
    resultsField
  );
+  const destIndex =


This logic is used in several places in DFA like useResultsViewConfig or deleteAnalyticsAndDestIndex... Might be out of scope of this PR but it's better to have a utility function (e.g. getDestinationIndex) so future updates to the logic can be more consistent.

Added util function in c849b80

alvarezmelissa87 · 2022-10-19T20:15:48Z

Updated and ready for a final look when you get a chance 🙏 cc @qn895, @peteharverson

…-ref HEAD~1..HEAD --fix'

qn895 · 2022-10-19T20:22:21Z

...alytics/pages/analytics_exploration/components/index_pattern_prompt/index_pattern_prompt.tsx

        <FormattedMessage
          id="xpack.ml.dataframe.analytics.dataViewPromptMessage"
-          defaultMessage="No data view exists for index{destIndex}. "
+          defaultMessage="No data view exists for index {destIndex}. "


This will leave an extra space before the period if the destIndex is undefined. "No data view exists for index ."

alvarezmelissa87 · 2022-10-19T21:28:17Z

@elasticmachine merge upstream

kibana-ci · 2022-10-19T22:32:24Z

💚 Build Succeeded

Buildkite Build
Commit: a891812

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1628	1629	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.4MB	3.4MB	+1.1KB

History

💔 Build #81591 failed e5f0676
💚 Build #81188 succeeded 098aa10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

qn895 · 2022-10-19T23:08:07Z

x-pack/plugins/ml/public/application/data_frame_analytics/common/get_destination_index.ts

+
+import { DataFrameAnalyticsConfig } from '../../../../common/types/data_frame_analytics';
+
+export const getDestinationIndex = (jobConfig: DataFrameAnalyticsConfig | undefined) =>


Suggestion to add if (!jobConfig) return ''; in the beginning so we don't have to check for it three times.

qn895 · 2022-10-20T15:05:20Z

LGTM assuming this is fixed (since there seems to be a problem with Github not showing all the changes).

* main: (57 commits) [Files] Filepicker (elastic#143111) [Infrastructure UI] Replace Lens table with EUI table and own api (elastic#142871) [api-docs] Daily api_docs build (elastic#143829) [api-docs] Daily api_docs build (elastic#143825) [api-docs] Daily api_docs build (elastic#143823) [Security Solution] Restructuring folders of Detection Engine + refactoring Rule Management (elastic#142950) [Dev tools] Fix performance issue with autocomplete suggestions (elastic#143428) [Security Solution] Disable ML rule's edit button link under basic license (elastic#143260) [Lens] Use the language-documentation package for formula (elastic#143649) [api-docs] Daily api_docs build (elastic#143811) [Security Solution] Fix missing title on inspect pop-up (elastic#143601) fix incorrect filters being passed to events table causing duplicate entries in our inpsect tool request tab (elastic#143239) [Security Solution][Endpoint] `get-file` response action kibana download file API (elastic#143708) Rely on refresh context to update stats independently of overview cards. (elastic#143308) [RAM] Rule event log - Fix incorrect results when filtering by message and outcome simultaneously (elastic#143119) [ML] Display link to create data view from error cases in data frame analytics results pages (elastic#143596) Update links in README :) (elastic#143675) Add more tests for ml_inference_logic (elastic#143764) skip failing test suite (elastic#143717) [DOCS] Add assignees to case APIs (elastic#143610) ...

add link to dataView creation when no dataView

098aa10

alvarezmelissa87 requested a review from a team as a code owner October 18, 2022 21:06

alvarezmelissa87 self-assigned this Oct 18, 2022

alvarezmelissa87 added :ml Feature:Data Frame Analytics ML data frame analytics features labels Oct 18, 2022

alvarezmelissa87 added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 18, 2022

alvarezmelissa87 requested review from peteharverson and qn895 October 18, 2022 21:09

peteharverson approved these changes Oct 19, 2022

View reviewed changes

qn895 reviewed Oct 19, 2022

View reviewed changes

alvarezmelissa87 added 2 commits October 19, 2022 14:03

update translations

7e8031b

add util function for destIndex

c849b80

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

e5f0676

…-ref HEAD~1..HEAD --fix'

qn895 reviewed Oct 19, 2022

View reviewed changes

Merge branch 'main' into ml-dfa-data-view-link

a891812

qn895 approved these changes Oct 20, 2022

View reviewed changes

alvarezmelissa87 merged commit 2eea2c2 into elastic:main Oct 20, 2022

kibanamachine added the backport:skip This PR does not require backporting label Oct 20, 2022

alvarezmelissa87 deleted the ml-dfa-data-view-link branch October 20, 2022 19:18


		import { DataFrameAnalyticsConfig } from '../../../../common/types/data_frame_analytics';

		export const getDestinationIndex = (jobConfig: DataFrameAnalyticsConfig \| undefined) =>

Conversation

alvarezmelissa87 commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 18, 2022

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 commented Oct 19, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 commented Oct 19, 2022

Uh oh!

kibana-ci commented Oct 19, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qn895 commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alvarezmelissa87 commented Oct 18, 2022 •

edited

Loading