Skip to content

[Management] Fix FF quirk with max width in the import saved object modal#14352

Merged
chrisronline merged 1 commit into
elastic:masterfrom
chrisronline:fix/browser_quicks_import_saved_objects_modal
Oct 6, 2017
Merged

[Management] Fix FF quirk with max width in the import saved object modal#14352
chrisronline merged 1 commit into
elastic:masterfrom
chrisronline:fix/browser_quicks_import_saved_objects_modal

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline commented Oct 6, 2017

Fixes #14350

FF:
ff

Chrome:
chrome

We still need to ensure there aren't any issues with the original code in IE, but if there are, hopefully this PR will solve that too.

/cc @snide

@chrisronline
Copy link
Copy Markdown
Contributor Author

@BigFunger verified this PR fixes IE too

Copy link
Copy Markdown
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we add an example to the UI Framework doc site to document this?

@chrisronline chrisronline merged commit 0fe4916 into elastic:master Oct 6, 2017
chrisronline added a commit that referenced this pull request Oct 6, 2017
chrisronline added a commit that referenced this pull request Oct 6, 2017
@chrisronline
Copy link
Copy Markdown
Contributor Author

Backport:

6.x: 21dcf16
6.0: 5f8474d

@chrisronline chrisronline deleted the fix/browser_quicks_import_saved_objects_modal branch October 6, 2017 19:10
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants