Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example plugins from new platform #14288

Merged

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Oct 4, 2017

The example plugins are starting to get in the way, so I think we should remove them.

Worst case, if we need them for some local development when trying out something, we can just do a git revert on this commit (and then remove the revert commit before pushing). We'll soon get to having real plugins.

@kimjoar kimjoar added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 4, 2017
@kimjoar kimjoar requested a review from azasypkin October 4, 2017 10:24
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimjoar kimjoar merged commit a1a56c9 into elastic:new-platform Oct 4, 2017
kimjoar added a commit to kimjoar/kibana that referenced this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants