[Lens] Add reduced time range option for formula#142709
Merged
dej611 merged 10 commits intoelastic:mainfrom Oct 10, 2022
Merged
[Lens] Add reduced time range option for formula#142709dej611 merged 10 commits intoelastic:mainfrom
dej611 merged 10 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Contributor
Contributor
Author
Yes. If we agree on that I'd say to change also the other tooltips to align to the same message (in another PR). |
mbondyra
approved these changes
Oct 10, 2022
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
Everything works as expected, I checked few scenarios (all with and without reduced time range set on switch (1h) to see if it's overwritten):
- count(reducedTimeRange='1d') - switch doesn't impact the result
- count(reducedTimeRange='1d') + 1 - switch doesn't impact the result
- count(reducedTimeRange='1d') + count(reducedTimeRange='1M') - switch doesn't impact the result
- count(reducedTimeRange='1d') + count() - switch impacts the result, the count() gets global switch value.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* ✅ Add tests for feature * ✨ Add feature and make tests work * ✨ Add more ui stuff * 🐛 Fix missing renders on advanced options change * 🔧 fix id issue * 👌 Shorter tooltip message
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* ✅ Add tests for feature * ✨ Add feature and make tests work * ✨ Add more ui stuff * 🐛 Fix missing renders on advanced options change * 🔧 fix id issue * 👌 Shorter tooltip message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #138725
Introduced the reduced time range advanced option for Formula.
Some testing notes:
More notes:
deboucedhook used for inputs. This bug has been fixed in this PR.replaceColumnhas been created to regenerate in any case a formula column on change. Perhaps it can be optimized further, leaving it as a follow up after some profiling.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers