refactor tagcloud to use tabify responseHandler#14266
Merged
Merged
Conversation
ppisljar
added
Feature:Visualizations
ppisljar
commented
Oct 3, 2017
Contributor
Author
There was a problem hiding this comment.
this is still messy ....
ideally filter event would take the aggConfig and value (instead of using aggConfigResult)
will address this in separate PR
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Oct 6, 2017
* refactor tagcloud to use tabify responseHandler * fixing issue with formatted word tag positioning
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Oct 6, 2017
* refactor tagcloud to use tabify responseHandler * fixing issue with formatted word tag positioning
ppisljar
added a commit
that referenced
this pull request
Oct 8, 2017
ppisljar
added a commit
that referenced
this pull request
Oct 8, 2017
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* refactor tagcloud to use tabify responseHandler * fixing issue with formatted word tag positioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tagcloud should use tabify responseHandler to make it easy to reuse.