Skip to content

[Infra] Make nav react to Hosts view enabled flag changing#142477

Merged
miltonhultgren merged 4 commits intoelastic:mainfrom
miltonhultgren:140996-reactive-host-view-setting
Oct 4, 2022
Merged

[Infra] Make nav react to Hosts view enabled flag changing#142477
miltonhultgren merged 4 commits intoelastic:mainfrom
miltonhultgren:140996-reactive-host-view-setting

Conversation

@miltonhultgren
Copy link
Copy Markdown
Contributor

@miltonhultgren miltonhultgren commented Oct 3, 2022 •
edited by kibanamachine
Loading

Summary

Closes #140996

This PR adds an app updater and consumes the hosts view enabled setting via an Observable instead so that changes to this setting are reacted to by changing the nav and deep links in the Infra app plugin.

How to test

  • Open the Infrastructure app from the global nav
  • See that Hosts is not visible in the Observability nav
  • Go to Stack Management, Advanced Settings and find the Host views enabled setting and enable it, click Save
  • Go back to Infrastructure app and observe that Hosts is now visible in the Observability nav without refreshing the page

@miltonhultgren miltonhultgren added Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Oct 3, 2022
@miltonhultgren miltonhultgren requested a review from a team as a code owner October 3, 2022 14:11
miltonhultgren
miltonhultgren commented Oct 3, 2022
View reviewed changes
Comment thread x-pack/plugins/infra/public/plugin.ts
fetchData: createMetricsFetchData(core.getStartServices),
});

const startDep$AndHostViewFlag$ = combineLatest([
Copy link
Copy Markdown
Contributor Author

@miltonhultgren miltonhultgren Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how to name this combination

matschaffer
matschaffer approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is the first rxjs review I've done, so no idea if this is idiomatic or not. But I can confirm it works after observing it with my own eyes 😉

I even turned it back off and the nav went away as expected.

I'm a little surprised it takes that much code to show/hide a link without refresh, but I trust you wouldn't leave it any more verbose than it has to be :)

matschaffer
matschaffer reviewed Oct 4, 2022
View reviewed changes
Comment thread x-pack/plugins/infra/public/plugin.ts Outdated
@miltonhultgren
Copy link
Copy Markdown
Contributor Author

miltonhultgren commented Oct 4, 2022 •
edited
Loading

@matschaffer

I'm a little surprised it takes that much code to show/hide a link without refresh, but I trust you wouldn't leave it any more verbose than it has to be :)

I think the rub is that it's two different down streams, one for the Observability chrome and one for Kibana core, the types and deconstructing code doesn't help make it any more compact either. :/

To go further, I think if the code was written to be more fully Observable driven it would, for example, accept a stream for deepLinks instead and then it would be more slim to simply push updates there (rather than having both the update and the initial value). At least that is my limited experience with RxJS, you either go all in or you end up with a lot of glue code.

@miltonhultgren
Copy link
Copy Markdown
Contributor Author

miltonhultgren commented Oct 4, 2022

@elasticmachine merge upstream

@miltonhultgren miltonhultgren enabled auto-merge (squash) October 4, 2022 07:15
@miltonhultgren
Copy link
Copy Markdown
Contributor Author

miltonhultgren commented Oct 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 4, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / analytics instrumented events from the browser Loaded Dashboard full loaded dashboard emits when hitting refresh
  • [job] [logs] FTR Configs #32 / analytics instrumented events from the browser Loaded Dashboard full loaded dashboard emits when query is set
  • [job] [logs] FTR Configs #32 / analytics instrumented events from the browser Loaded Dashboard full loaded dashboard should emit the "Loaded Dashboard" event when done loading complex dashboard

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 84.6KB 84.8KB +204.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@miltonhultgren miltonhultgren merged commit d60acf8 into elastic:main Oct 4, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2022
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@miltonhultgren @kibanamachine
[Infra] Make nav react to Hosts view enabled flag changing (elastic#1…
5619df4 
…42477)

* [Infra] Make nav react to Hosts view enabled flag changing (elastic#140996)

* Move comment to more relevant location

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d60acf8)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 4, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
@kibanamachine @miltonhultgren
[Infra] Make nav react to Hosts view enabled flag changing (#142477) (#…
30b43ff 
…142585)

* [Infra] Make nav react to Hosts view enabled flag changing (#140996)

* Move comment to more relevant location

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d60acf8)

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@miltonhultgren @kibanamachine @WafaaNasr
[Infra] Make nav react to Hosts view enabled flag changing (elastic#1…
ee47671 
…42477)

* [Infra] Make nav react to Hosts view enabled flag changing (elastic#140996)

* Move comment to more relevant location

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@miltonhultgren @kibanamachine @WafaaNasr
[Infra] Make nav react to Hosts view enabled flag changing (elastic#1…
f8542af 
…42477)

* [Infra] Make nav react to Hosts view enabled flag changing (elastic#140996)

* Move comment to more relevant location

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Oct 12, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matschaffer matschaffer matschaffer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Infra Monitoring UI] use observable to watch for config changes

4 participants

@miltonhultgren @kibana-ci @kibanamachine @matschaffer