[ResponseOps][Alerting] Elasticsearch query rule type allows SIZE: 0, but flags as error on re-edit #142225
Merged
doakalexi merged 6 commits intoelastic:mainfrom Oct 10, 2022
Merged
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
Contributor
Author
sure! I can do that |
ersin-erdal
reviewed
Oct 10, 2022
ersin-erdal
approved these changes
Oct 10, 2022
Contributor
ersin-erdal
left a comment
There was a problem hiding this comment.
Left a note for a small fix.
After that, LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Resolves #138759
Summary
Adds a null check to the form validation so that a value of 0 doesnt cause errors.
Checklist
To verify