[stack_functional_integration] remove esArchiver service#141842
Merged
spalger merged 1 commit intoelastic:mainfrom Sep 26, 2022
Merged
[stack_functional_integration] remove esArchiver service#141842spalger merged 1 commit intoelastic:mainfrom
spalger merged 1 commit intoelastic:mainfrom
Conversation
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
spalger
force-pushed
the
fix/stack_functional_integration-config
branch
from
4474db3 to
a11f87f
Compare
jbudz
approved these changes
Sep 26, 2022
marius-dr
approved these changes
Sep 26, 2022
Member
marius-dr
left a comment
marius-dr
left a comment
There was a problem hiding this comment.
LGTM. gave it a run on integration-test as well and it passed.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
LeeDr
added
backport:prev-minor
and removed
backport:skip
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Oct 20, 2022
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #140680 we moved the esArchiver service into a package and changed the way it worked. This ended up breaking the
x-pack/test/stack_functional_integration/configs/config.stack_functional_integration_base.jsFTR config because it used a custom esArchiver provider to customize the esArchiverbaseDir. Rather than continue replacing the esArchiver service this PR adds the ability to configure this path via config instead.