Filter out error docs from standalone cluster lists#140102
Merged
matschaffer merged 4 commits intoelastic:mainfrom Sep 9, 2022
Merged
Filter out error docs from standalone cluster lists#140102matschaffer merged 4 commits intoelastic:mainfrom
matschaffer merged 4 commits intoelastic:mainfrom
Conversation
Not working yet.
matschaffer
added
the
Team:Infra Monitoring UI - DEPRECATED
Contributor
|
@matschaffer this is the right fix but we also need the |
This was referenced Sep 6, 2022
standaloneClusterFilter already had this covered, but the field wasn't mapped initially.
matschaffer
changed the title
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
Marking this ready for review, but admittedly the testing story is pretty thin. I'll try to work on a cleaner flow today. In the mean time I'm pretty sure @klacabane and @crespocarlos have a sufficient level of elastic-package tribal knowledge to know to validate the change. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @matschaffer |
klacabane
added
release_note:skip
klacabane
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures error docs won't lead to erroneous "Standalone cluster" entries.
Fixes elastic/integrations#4011
Requires
#137904andelastic/integrations#4147to test functionality.Keeping as draft until those are merged so we can test properly.All merged, just make sure you have main kibana & packages.Testing
(Details WIP)