[7.17] Remove file-type dependency via jimp (#137214)#139436
Merged
jeramysoucy merged 6 commits intoelastic:7.17from Aug 29, 2022
Merged
[7.17] Remove file-type dependency via jimp (#137214)#139436jeramysoucy merged 6 commits intoelastic:7.17from
jeramysoucy merged 6 commits intoelastic:7.17from
Conversation
* Removed file-type from package.json deps. Updated jimp to 0.16.1. Updated light & dark dashboard baseline screenshots to resolve failure due to resize degradation. * Replaced jimp with sharp and pixelmatch. Eliminates several deps, including file-type. Eliminates quality degradation from image resizing. * Fixed copy paste error, which lead to pass positives and errors. * Integrated updateBaselines flag into dashboards report testing. Fixed sharp resize to fit and not truncate the original image. * Removed accidental '.only' * Reverted area chart baseline. * Removed explicit declaration of sharp from package.json. * Adjusted dashboard screenshot size in attempt to eliminate layout scaling issues in CI testing. * Reverted dashboard screenshot size. Lowered tolerance in dashboard PNG reporting tests to force failure and collect CI screenshots. * Changed session save location for dashboard report images for better CI reporting. * Fixed small dashboard baseline screenshot with correct aspect ratio. * Updated 2 basline screenshots from CI. Lowered PNG match tolerance for dashboard screenshots to 1% for investigation of remaining screens. * Update of dashboard controls light mode baseline. Change of forced container width size in large dashboard layout test. * Updated dashboard controls dark mode baseline screenshot. Adjusted forced container width in large dashboard layout test for troubleshooting. * Lowering tolerance of PNG compare tests from 9% to 1% for troubleshooting. Replaced references to dedundant image service with existing, more adopted reporting service. Ideally, the PNG functions of the reporting service would be merged with the screenshot service as an image service. * Reverting tolerance of PNG compares to 0.09. Will create GH issues for specific teams to investigate. * Implemented PngService to provide an accessible single reference to PNG compare testing. Removed redundant implementations and references. * Updated service reference and call to png compare function left out of last commit. * Updated another missed PNG reference. * Removed superfluous parameter. * Update after bootstrap * Updated area chart baseline to match new render with panel filters. * Reverted limits in dashboard snapshot tests to original values. * Merge and rebuild. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit de9b7c6) # Conflicts: # package.json # test/functional/screenshots/baseline/area_chart.png # test/functional/screenshots/baseline/dashboard_controls_dark.png # test/functional/screenshots/baseline/dashboard_controls_light.png # test/functional/services/lib/compare_pngs.ts # x-pack/test/functional/apps/dashboard/group3/reporting/reports/baseline/small_dashboard_preserve_layout.png # x-pack/test/functional/apps/dashboard/reporting/screenshots.ts # x-pack/test/functional/apps/maps/group3/reports/index.ts # x-pack/test/functional/services/index.ts # x-pack/test/reporting_functional/reporting_and_timeout/index.ts # x-pack/test/reporting_functional/services/scenarios.ts # yarn.lock
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation