Skip to content

[7.17] Upgrade micromatch from v3.1.10 to v4.0.5 (#139187)#139271

Closed
watson wants to merge 4 commits intoelastic:7.17from
watson:backport/7.17/pr-139187
Closed

[7.17] Upgrade micromatch from v3.1.10 to v4.0.5 (#139187)#139271
watson wants to merge 4 commits intoelastic:7.17from
watson:backport/7.17/pr-139187

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Aug 23, 2022

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 491a461)

# Conflicts:
#	package.json
#	yarn.lock
@watson watson added the backport This PR is a backport of another PR label Aug 23, 2022
@watson watson enabled auto-merge (squash) August 23, 2022 08:55
@watson
Copy link
Copy Markdown
Contributor Author

watson commented Aug 31, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Aug 31, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson
Copy link
Copy Markdown
Contributor Author

watson commented Aug 31, 2022

@spalger I've been puzzled by the linting errors on this PR for a while and suddenly realize that it might be related to #136911 which you created in main not that long ago:

image

They all seem to be the same:

'@kbn/eslint/no-restricted-paths' rule is disabled but never reported  eslint-comments/no-unused-disable

I'm not sure why this PR suddenly triggers those?!? Maybe the micromatch library is used by eslint and there's a bug in eslint in 7.17 that means it has to use an older version of micromatch? 🤷

In any case... with your knowledge of this eslint rule, do you think it would be safe to simply remove these no-unused-disable lines from the code in 7.17 in this PR?

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Aug 31, 2022

That wouldn't shock me @watson, @kbn/eslint/no-restricted-paths is implemented in the repository and uses micromatch: https://github.com/elastic/kibana/blob/7.17/packages/kbn-eslint-plugin-eslint/rules/no_restricted_paths.js#L31

Unfortunately I'm unable to bootstrap 7.17 locally or I'd help debug this.

@watson
Copy link
Copy Markdown
Contributor Author

watson commented Oct 10, 2022

We have decided not to complete this backport due to the difficulty in getting the tests to pass (see above comments).

@watson watson closed this Oct 10, 2022
auto-merge was automatically disabled October 10, 2022 05:01

Pull request was closed

@watson watson deleted the backport/7.17/pr-139187 branch October 10, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants