[Discover] Support storing time with saved searches by jughosta · Pull Request #138377 · elastic/kibana

jughosta · 2022-08-09T11:07:12Z

Summary

This PR adds support for storing the current time range and refresh interval with saved searches. Once such saved search is opened, it will restore the time filter. Embeddables on Dashboard won't use these data.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

jughosta · 2022-08-09T18:27:00Z

+        label={
+          <FormattedMessage
+            id="discover.topNav.saveModal.storeTimeWithSearchFormRowLabel"
+            defaultMessage="Store time with search"


Hi @gchaps ! We are adding a new toggle to the Save Search modal on Discover page. Do you have suggestions for the copy?

How about something like this

Store time with saved search
Update the time filter and refresh interval to the current selection when using this search.

Updated. Thanks, @gchaps !

jughosta · 2022-08-10T12:24:50Z

@elasticmachine merge upstream

elasticmachine · 2022-08-10T13:34:01Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta · 2022-08-11T07:27:34Z

@elasticmachine merge upstream

kertal

Code LGTM, great work 🎉 ! Tested locally and a-la-carte and works as expected 👍 . One thing I noted but that's not specific to this PR, once you saved there's no good way to check if a saved search stores the time or not. So actually, you've to open and see that it does. This is the same with dashboard. ideally we would have a indicator in the saved search list if a saved search is configured this way ... or a tag that's automatically assigned (now thinking of he who will bring tags to Discover aka @davismcphee )

davismcphee

Code changes LGTM, pulled and tested locally and works great! You'll make some users waiting five years very happy. Also I agree with @kertal about an indicator being a good idea, but also since it's the same in Dashboard I think it's good for now.

kertal · 2022-08-11T15:44:30Z

closing an issue with just four digits will not happen too often in the future, #9761. This is like resolving issues of your ancestors, let's spend a minute in silence ... or just don't write anything in slack for a minute

jughosta · 2022-08-12T07:52:01Z

Thanks for the reviews! Going to merge after #138388

…h-search # Conflicts: # src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx # src/plugins/discover/public/application/main/utils/persist_saved_search.ts # src/plugins/saved_search/public/services/saved_searches/types.ts

jughosta · 2022-08-15T08:36:42Z

@elasticmachine merge upstream

jughosta · 2022-08-15T14:57:44Z

@elasticmachine merge upstream

jughosta · 2022-08-16T13:01:22Z

@elasticmachine merge upstream

jughosta · 2022-08-22T08:28:37Z

@elasticmachine merge upstream

rudolf

The CI failure due to the field limit stems from the way esArchiver creates the .kibana index. It's hard to test these fixes without a PR like this one, so I decided to add a commit directly to this PR which will hopefully solve it.

rudolf · 2022-08-22T20:43:43Z

-        "routing_partition_size": "1"
+        "routing_partition_size": "1",
+        "mapping": {
+          "total_fields": { "limit": 1500 }


Here and in all the other mappings.json files I explicitly set the field limit to 1500. When FTR has an esArchive with the index name .kibana_$KIBANA_PACKAGE_VERSION_001 this creates an index with the current version number like .kibana_8.5.0_001. Because the index is already using the latest version number no migrations are applied and so the migration service will not update the field limit of this index.

So any time esArchiver creates such an "already migrated to the latest version" index we need to explicitly set the field limit. Because most tests don't delete the .kibana index once it exists, but merely "cleans" it by deleting all current saved objects, these archives can break other test suites that didn't even load the archive.

The alternative is to always delete the .kibana index for every test suite, but this is simply too time consuming and adds an incredible amount of time to each CI run.

thx @rudolf for taking care of this!

Thanks @rudolf!

kertal · 2022-08-23T04:54:23Z

@elasticmachine merge upstream

kibana-ci · 2022-08-23T05:54:59Z

💚 Build Succeeded

Buildkite Build
Commit: 017f560

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	525	527	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`discover`	73	76	+3
`savedSearch`	39	42	+3
total			+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	461.1KB	462.7KB	+1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedSearch`	4.7KB	4.9KB	+192.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id	before	after	diff
`search`	15	22	+7

Unknown metric groups

API count

id	before	after	diff
`discover`	90	93	+3
`savedSearch`	39	42	+3
total			+6

History

💔 Build #66586 failed e96171e
💔 Build #66296 failed 727ae0d
💔 Build #65389 failed dfd7780
💔 Build #65117 failed 303b241
💔 Build #65056 failed accd088

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

azasypkin

Changes in SO/Spaces API integration tests LGTM.

* [Discover] Implement UI for storing time with a saved search * [Discover] Save time range data with a saved search * [Discover] Improve updating of values * [Discover] Restore time range after loading a saved search * [Discover] Add time range validation * [Discover] Add refresh interval validation * [Discover] Update how saved search gets restored * [Discover] Improve tests * [Discover] Update tests * [Discover] Improve type imports * [Discover] Update copy * [Discover] Fix types after the merge * [Discover] Update test name * [Discover] Fix types * [Discover] Update mapping * [Discover] Update mapping * Explicitly set field limit for .kibana_ esArchives Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

jughosta added 5 commits August 8, 2022 16:06

[Discover] Implement UI for storing time with a saved search

c5f2a8d

[Discover] Save time range data with a saved search

8245936

[Discover] Improve updating of values

4b87636

[Discover] Restore time range after loading a saved search

f3d1c11

[Discover] Add time range validation

7a8b930

jughosta added Feature:Discover Discover Application release_note:feature Makes this part of the condensed release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.5.0 labels Aug 9, 2022

jughosta self-assigned this Aug 9, 2022

jughosta added 4 commits August 9, 2022 13:35

[Discover] Add refresh interval validation

cff8315

[Discover] Update how saved search gets restored

8bc033d

[Discover] Improve tests

29ac1af

[Discover] Update tests

85326f7

jughosta commented Aug 9, 2022

View reviewed changes

Merge branch 'main' into 9761-store-time-with-search

0c86e78

jughosta marked this pull request as ready for review August 10, 2022 13:33

jughosta requested a review from a team as a code owner August 10, 2022 13:33

[Discover] Improve type imports

01eb5b6

kibanamachine and others added 2 commits August 11, 2022 03:27

Merge branch 'main' into 9761-store-time-with-search

37ed763

[Discover] Update copy

de80ceb

kertal approved these changes Aug 11, 2022

View reviewed changes

davismcphee approved these changes Aug 11, 2022

View reviewed changes

jughosta added 2 commits August 12, 2022 15:29

[Discover] Fix types after the merge

4813a09

jughosta added 2 commits August 12, 2022 15:37

[Discover] Update test name

59b9852

[Discover] Fix types

a9beeaf

kibanamachine and others added 3 commits August 15, 2022 04:36

Merge branch 'main' into 9761-store-time-with-search

708e38c

[Discover] Update mapping

7a9669a

[Discover] Update mapping

accd088

Merge branch 'main' into 9761-store-time-with-search

303b241

Merge branch 'main' into 9761-store-time-with-search

dfd7780

kibanamachine and others added 2 commits August 22, 2022 04:28

Merge branch 'main' into 9761-store-time-with-search

727ae0d

Explicitly set field limit for .kibana_ esArchives

e96171e

rudolf requested a review from a team as a code owner August 22, 2022 20:38

rudolf reviewed Aug 22, 2022

View reviewed changes

Merge branch 'main' into 9761-store-time-with-search

017f560

azasypkin approved these changes Aug 23, 2022

View reviewed changes

jughosta merged commit 1a70f6f into elastic:main Aug 23, 2022

kibanamachine added the backport:skip This PR does not require backporting label Aug 23, 2022

rudolf mentioned this pull request Oct 31, 2022

Bump field limit for esArchiver indices using #144272

Merged

9 tasks

Conversation

jughosta commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

jughosta Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

gchaps Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta commented Aug 10, 2022

Uh oh!

elasticmachine commented Aug 10, 2022

Uh oh!

jughosta commented Aug 11, 2022

Uh oh!

kertal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

kertal commented Aug 11, 2022

Uh oh!

jughosta commented Aug 12, 2022

Uh oh!

jughosta commented Aug 15, 2022

Uh oh!

jughosta commented Aug 15, 2022

Uh oh!

jughosta commented Aug 16, 2022

Uh oh!

jughosta commented Aug 22, 2022

Uh oh!

rudolf left a comment

Choose a reason for hiding this comment

Uh oh!

rudolf Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

kertal Aug 23, 2022

Choose a reason for hiding this comment

Uh oh!

jughosta Aug 23, 2022

Choose a reason for hiding this comment

Uh oh!

kertal commented Aug 23, 2022

Uh oh!

kibana-ci commented Aug 23, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

Saved Objects .kibana field count

API count

History

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jughosta commented Aug 9, 2022 •

edited

Loading

kertal left a comment •

edited

Loading