Skip to content

[Maps] fix Filters applied to map visualization not preserved when added to dashboard#138188

Merged
nreese merged 16 commits intoelastic:mainfrom
nreese:issue_91282
Aug 16, 2022
Merged

[Maps] fix Filters applied to map visualization not preserved when added to dashboard#138188
nreese merged 16 commits intoelastic:mainfrom
nreese:issue_91282

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Aug 4, 2022

Fixes #91282

To test:

  1. create map with query and/or filter. Save map
  2. Add map to dashboard. Verify map is narrowed by query and/or filter saved with map.

Screen Shot 2022-08-15 at 11 59 47 AM

Screen Shot 2022-08-15 at 11 59 37 AM

@nreese nreese changed the title fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed [Maps] fix Filters applied to map visualization not preserved when added to dashboard Aug 5, 2022
@nreese nreese added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This PR does not require backporting v8.5.0 labels Aug 16, 2022
@nreese nreese marked this pull request as ready for review August 16, 2022 12:02
@nreese nreese requested a review from a team as a code owner August 16, 2022 12:02
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from nickpeihl August 16, 2022 12:03
Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tested in chrome and code review

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Aug 16, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 252 255 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +1.1KB
Unknown metric groups

API count

id before after diff
maps 255 256 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 7303ef8 into elastic:main Aug 16, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
…ded to dashboard (elastic#138188)

* [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed

* add min-width to mapFeatureTooltip__propertyLabel

* [Maps] fix Filters applied to map visualization not preserved when added to dashboard

* clean up

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* clean-up

* publish query and filter to container

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix checks

* tslint and add to bounds filter

* functional test

* review feedback

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Maps release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] Filters applied to map visualization not preserved when added to dashboard

6 participants