Skip to content

[Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed #138054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed #138054

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a9b14
[Maps] fix Tool tip with large field list exceeds browser screen and …
nreese Aug 3, 2022
5f45c00
add min-width to mapFeatureTooltip__propertyLabel
nreese Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
286 changes: 149 additions & 137 deletions ...ts/mb_map/tooltip_control/features_tooltip/__snapshots__/feature_properties.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion ...gins/maps/public/connected_components/mb_map/tooltip_control/features_tooltip/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
.mapFeatureTooltip_table {
width: 100%;
max-height: calc(49vh - #{$euiSizeXL * 2});

td {
padding: $euiSizeXS;
}
}

.mapFeatureTooltip_tableWrapper {
overflow: auto;
max-height: calc(49vh - 64px);
}

.mapFeatureTooltip_row {
border-bottom: 1px solid $euiColorLightestShade;
}
Expand Down
8 changes: 5 additions & 3 deletions ...ublic/connected_components/mb_map/tooltip_control/features_tooltip/feature_properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,11 @@ export class FeatureProperties extends Component<Props, State> {
});

return (
<table className="eui-yScrollWithShadows mapFeatureTooltip_table" ref={this._tableRef}>
<tbody>{rows}</tbody>
</table>
<div className="mapFeatureTooltip_tableWrapper">
<table className="eui-yScrollWithShadows mapFeatureTooltip_table" ref={this._tableRef}>
<tbody>{rows}</tbody>
</table>
</div>
);
}
}