[Discover] Fix legacy sort saved search stored in dashboard saved objects

[kertal]

Summary

This PR fixes the handling of legacy sort URL stored in Dashboards. Those URLs are automatically migrated on the fly like it works in main Discover.

It contains a refactoring migrating sort functions from public/components/doc_table/utils to public/utils, away from classic table, since it was already shared among different parts of our plugin.
Those functions now are also used in a better way in our embeddable code, centralizing handling of the sort property of state and its usage in data fetching. This change fixes the bug.

Fixes #81559

Testing

• Create a dashboard with a single saved search
• Goto Saved Objects, export this dashboard, related objects are not needed
• Edit the dashboard locally, search for sort, it could look like this.
  "sort\":[[\"taxful_total_price\",\"asc\"],[\"order_date\",\"desc\"]],
  Legacy sort wasn't an array of arrays, but a single array containing the property to sort by, and the direction, so it needs to be changed like this
  "sort\":[\"taxful_total_price\",\"asc\"],
• Save the change and upload it again
• Now it should be sorted by this single field correctly

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kertal]

@elasticmachine merge upstream

[jughosta]

Nice refactoring! 🙂
Left some questions.

[kertal]

@elasticmachine merge upstream

[jughosta]

Thanks for fixing this case!

I noticed one weird thing when a saved search configuration on Dashboard has legacy format for a column "sort":["extension","desc"]. It replaces the current sorting setting when trying to add another sort criteria on Dashboard (on Discover pages it works as expected)

Is it something we can improve?

[kertal]

definitely! another good catch 🎣 ! thx!

[kertal]

this is interesting, because it worked for me locally ... maybe you could export the dashboard saved object and send it to me so I could reproduce? many thx!

[kertal]

thx for the saved object! So the problem here is that extension is a field that's not sortable, extension.keyword is sortable. when changing the sort, this field is removed from sorting (sorted out 😃). Since the sorting state of the UI can only be changed with manually tweaking the saved search, I think we're safe here. However there might be a potential follow up taking care of the behavior in Discover, which seems to work differently in this case.

[kertal]

@elasticmachine merge upstream

[jughosta]

Thanks for fixing this old issue and for the refactoring! LGTM 👍

[jughosta]

We merge it after #138388, right?

[kertal]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 3604da6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	462.7KB	462.3KB	-434.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
discover	5	4	-1

History

• 💚 Build #66389 succeeded 130e99b
• 💔 Build #66319 failed 6d14142
• 💚 Build #64604 succeeded f60ba59
• 💚 Build #64195 succeeded 54a7a91
• 💚 Build #63475 succeeded 289062c
• 💚 Build #63316 succeeded c5f674e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal