Fix blank index pattern selector in Discover#13715
Merged
Bargs merged 1 commit intoelastic:masterfrom Aug 28, 2017
Merged
Conversation
ui-select-match's expression was expecting an IndexPattern object, but the indexPatternList passed to ui-select-choices contained SavedObject instances due to the [SavedObjectsClient refactor][1]. This wasn't a problem most of the time because switching index patterns caused the entire directive to get destroyed and re-created. However, when the directive didn't get re-created (for example, when clicking the already selected pattern) it would result in a blank select box. Fixes elastic#13080 [1]: elastic#12719
tylersmalley
approved these changes
Aug 25, 2017
weltenwort
approved these changes
Aug 28, 2017
Bargs
added a commit
that referenced
this pull request
Aug 28, 2017
ui-select-match's expression was expecting an IndexPattern object, but the indexPatternList passed to ui-select-choices contained SavedObject instances due to the [SavedObjectsClient refactor][1]. This wasn't a problem most of the time because switching index patterns caused the entire directive to get destroyed and re-created. However, when the directive didn't get re-created (for example, when clicking the already selected pattern) it would result in a blank select box. Fixes #13080 [1]: #12719
Bargs
added a commit
that referenced
this pull request
Aug 28, 2017
ui-select-match's expression was expecting an IndexPattern object, but the indexPatternList passed to ui-select-choices contained SavedObject instances due to the [SavedObjectsClient refactor][1]. This wasn't a problem most of the time because switching index patterns caused the entire directive to get destroyed and re-created. However, when the directive didn't get re-created (for example, when clicking the already selected pattern) it would result in a blank select box. Fixes #13080 [1]: #12719
Bargs
added a commit
that referenced
this pull request
Aug 28, 2017
ui-select-match's expression was expecting an IndexPattern object, but the indexPatternList passed to ui-select-choices contained SavedObject instances due to the [SavedObjectsClient refactor][1]. This wasn't a problem most of the time because switching index patterns caused the entire directive to get destroyed and re-created. However, when the directive didn't get re-created (for example, when clicking the already selected pattern) it would result in a blank select box. Fixes #13080 [1]: #12719
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui-select-match's expression was expecting an IndexPattern object, but
the indexPatternList passed to ui-select-choices contained SavedObject
instances due to the SavedObjectsClient refactor. This wasn't a
problem most of the time because switching index patterns caused the
entire directive to get destroyed and re-created. However, when the
directive didn't get re-created (for example, when clicking the already
selected pattern) it would result in a blank select box.
Fixes #13080