Skip to content

[Discover] Fix storybook dependencies#137037

Merged
dimaanj merged 3 commits intoelastic:mainfrom
dimaanj:clean-up-storybook-config
Aug 1, 2022
Merged

[Discover] Fix storybook dependencies#137037
dimaanj merged 3 commits intoelastic:mainfrom
dimaanj:clean-up-storybook-config

Conversation

@dimaanj
Copy link
Copy Markdown
Contributor

@dimaanj dimaanj commented Jul 25, 2022

Summary

This is a follow up of #136702 which fixes stories with unified search.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.4.0 labels Jul 25, 2022
@dimaanj dimaanj self-assigned this Jul 25, 2022
…p-storybook-config

# Conflicts:
#	src/plugins/discover/public/__mocks__/__storybook_mocks__/with_discover_services.tsx
@dimaanj dimaanj marked this pull request as ready for review July 28, 2022 07:45
@dimaanj dimaanj requested a review from a team as a code owner July 28, 2022 07:45
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj dimaanj changed the title [Discover] Clean up storybook config [Discover] Fix storybook dependencies Jul 28, 2022
@dimaanj dimaanj added v8.5.0 WIP Work in progress labels Jul 29, 2022
@dimaanj
Copy link
Copy Markdown
Contributor Author

dimaanj commented Aug 1, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works now as expected:
Bildschirmfoto 2022-08-01 um 11 42 42

@dimaanj dimaanj added auto-backport Deprecated - use backport:version if exact versions are needed backport:prev-minor and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 1, 2022
@dimaanj dimaanj merged commit 90e47dd into elastic:main Aug 1, 2022
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 1, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 90e47dd)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 1, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 90e47dd)

Co-authored-by: Dmitry Tomashevich <39378793+dimaanj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.4.0 v8.5.0 WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants