[kibana_utils] remove root index.ts file#137003
Merged
spalger merged 3 commits intoelastic:mainfrom Jul 25, 2022
Merged
Conversation
spalger
force-pushed
the
fix/kibana_utils/no-root-plugin-imports
branch
from
6be376c to
e3f6bdd
Compare
spalger
changed the title
spalger
force-pushed
the
fix/kibana_utils/no-root-plugin-imports
branch
from
e3f6bdd to
5c0908d
Compare
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 22, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 25, 2022
* [kibana_utils] remove root-level index.ts file * autofix all imports (cherry picked from commit 676be86)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the kibana_utils plugin there is an
index.tsfile outside of theserver,public, andcommondirectories that just re-exports somecommonexports. In the package system this will need to be removed and the common package will need to be imported directly. Additionally, we're working to get a step closer to that state in #136911 and these changes were extracted from there so that we are importing the exact plugin-section we want.To accomplish this we used the
@kbn/eslint/module_migrationrule to remap all imports for@kbn/kibana-utils-plugin(exactly) with@kbn/kibana-utils-plugin/commonand removed the old index.ts file.