[Canvas] Removed function reference docs generator#136955
Merged
cqliu1 merged 1 commit intoelastic:mainfrom Jul 22, 2022
Merged
[Canvas] Removed function reference docs generator#136955cqliu1 merged 1 commit intoelastic:mainfrom
cqliu1 merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jul 22, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm removing this component that only appears in dev. I originally created this component as an easy way to generate our Canvas expression function reference docs directly from the function definitions.
The reason I'm removing this component is because it violates the no boundary crossing rule Spencer is introducing in #136911 as part of his plugin package project. Since it's just a tool visible in dev primarily by me, there is no reason it needs to be checked into main, and if necessary in the future, it should be fairly easy to create a better script for this or to restore it temporarily just to update our function docs.
There should be no user-facing changes.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers