[Discover] Remove document explorer header column edit data view field functionality#136743
Merged
stratoula merged 2 commits intoelastic:unified-search-text-based-langfrom Jul 21, 2022
Conversation
kertal
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @kertal |
stratoula
added a commit
that referenced
this pull request
Jul 26, 2022
* [Discover] Supports SQL query language (#134429) * Move the add dataview action above the dataview selection panel * Implements a new selectable on the dataview picker for the text based languages * Implementation of the transition modal when on SQL mode and select a dataview * Fix es lint * Change switch modal button modal icon * Lazy load components * Small changes on the styling of the switch without saving button * Initialization of mocaco editor * Change to the type * Fixes types checks * New submit button for query mode * Implememtation of the expanded mode of the editor * Implement documentation * Implementation of the oneliner mode with ellipsis * Some fixes on the resizer * Implementation of the errors layout, WIP * Fetch SQL data in Discover * Fix expression test * Fix editor zIndex * Fix types error * Fix type check in Discover * Fix more types * some CI fixes * Fixes * Cleanup after merge * Remove from state * Connect search errors with the unified search editor * Add error mrkers in unified search editor * Save and open saved searches * Filter out saved searches from text based languages * Some fixes * Fix unit tests * Fix checks * On save and exit modal implementation * Add shortcut on the editor for submit query * Fix wrong condition * Initial types change * Use regex to find the index pattern string * Fix some types and cleanup * Fix types * Fix some types * Further fixes * More fixes * More fixes * Fix visualize types * more * More fixes * Fixes more types * Fix dashboard types * Fix dashboard types * Controls plugin types * Fix Lens types * Fix data plugin types * Fix types in Lens 2 * buildEsConfig type fixes * Fix observability types * Fix maps types * data visualizer types * Fix ml types * xpack rest types * Fix jest test * Fix * Move helper functions to es config * fix bug on breadcrumb click * Fix time field bug * Add enableSql advanced setting to discover for enabling the sql mode * Make the documentation component more dynamic * Add some comments, improvements * Enhance storybook with the textbased languages * Update storybook with the error state of the editor * Adds a readme for the editor and fixes the modal mobile version * [Discover] improve test and storybook for new data type * [Discover] add functional tests * Add aggregate functions to the documentation * [Discover] fix tests * Add some unit tests * [Discover] fix linting * [Discover] update linting * More unti tests * Dataview picker unit tests * Fix a bug on the dataview picker * Add unit tests for the editor * Fix jest test * [Discover] apply suggestions * [Discover] adjust styles * Fix some bugs and select columns in the sql mode * [Discover] fix eslint and tests * [Discover] update unit tests * Fix bug on transitioning from sql mode to dataview mode * [Discover] fix tests * Design fixes on the errors messages * [Discover] fix ci * Update the columns only if the query changes * [Discover] change isPlainRecord retrieval method * Fix bug on cleanup * Fix bug on opening a saved search * [Discover] fix comments * [Discover] fix bug with browser refresh * [Discover] fix functional * [Discover] fix another functional * Fix ordering lost when the user refreshes the browser * [Discover] revert use_discover_state * [Discover] revert functional impl * Fix security solution types * Casting dashboard plugin * Revert change * type param * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Revert types changes * More reverts * Types fixes * Fix Discover jest test * Fix context app jest test * Final types changes * Fixes unit test Co-authored-by: Dzmitry Tamashevich <diaamnj@mail.ru> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> * Fix types * Fix jest test * More design fixes * Update advanced setting description * Further design changes * [Discover] Remove document explorer header column edit data view field functionality (#136743) * remove Edit data view field for SQL * Fix the fix * [Discover] Implement SQL data fetching for embeddable (#136793) * remove Edit data view field for SQL * Fix the fix * Implement SQL for embeddable * Fix non-saved-search embeddables * Fix reporting bundle size * Allow filters on dashboard level for sql searches * Fix the radius on the editor * Add vertical padding on the editor * Change the theme * Address PR comments * Fix types * Address some of the comments * Fix bug on transitioning from SQL to dataview mode with the modal dismissed * More types fixes * Design review comments * Discovery team review comments * Fix jest tests * Fix bug on navigating from the SQL mode to the dataview mode and back in sql mode by clicking the breadcrumb * Update src/plugins/discover/public/application/main/hooks/use_discover_state.ts Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> * Add padding to the top of the editor without creating any bug * Add some padding to the bottom without creating any bug * Fixes undo bug * Fix confusing naming of variable * Fix nested selects * Update texts for transition modal and warning * Make it work with dashboard Query * Address some of the comments Co-authored-by: Dzmitry Tamashevich <diaamnj@mail.ru> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing field editing in the columns header when using SQL