Skip to content

[Fleet] Fleet Server flyout fixes #136566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 19, 2022
Merged

[Fleet] Fleet Server flyout fixes #136566

merged 6 commits into from
Jul 19, 2022

Conversation

@kpollich
Copy link
Member

@kpollich kpollich commented Jul 18, 2022

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jul 18, 2022
@kpollich kpollich requested a review from a team as a code owner July 18, 2022 19:46
@kpollich kpollich self-assigned this Jul 18, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 18, 2022

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet self-requested a review July 18, 2022 20:02
@nchaulet
Copy link
Member

nchaulet commented Jul 18, 2022

@kpollich I did a manual test and looks like the button add Agent at the top (the with data-test-subj="addAgentBtnTop" ) is still opening standalone by default after adding a Fleet Server maybe something we want to fix no?

@kpollich
Copy link
Member Author

kpollich commented Jul 18, 2022

@nchaulet Yeah that probably makes sense but will probably be a little more complicated to implement. I can take a look at doing that.

Honestly I feel that we should almost always default to managed mode when opening the agent flyout, but I remember there being a good reason for not defaulting to managed mode in these flyouts previously. Standalone mode seems more like an escape hatch, but I might be missing something.

@nchaulet
Copy link
Member

nchaulet commented Jul 18, 2022 •
edited
Loading

Honestly I feel that we should almost always default to managed mode when opening the agent flyout, but I remember there being a good reason for not defaulting to managed mode in these flyouts previously. Standalone mode seems more like an escape hatch, but I might be missing something.

Yes I think we default to standalone when Fleet server is not setup, but it should probably change when Fleet Server is setup, I think it's not that hard to fix know you introduced the displayInstructions variable and refresh the context

@jen-huang jen-huang added v8.3.3 and removed v8.3.0 labels Jul 18, 2022
@kpollich
Copy link
Member Author

kpollich commented Jul 19, 2022

@nchaulet I made the change discussed to use fleet mode when fleet server is set up + standalone mode when it isn't in 4949171

nchaulet
nchaulet approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the top add agent button, LGTM 🚀

@kpollich kpollich enabled auto-merge (squash) July 19, 2022 13:42
@kpollich
Copy link
Member Author

kpollich commented Jul 19, 2022

@elasticmachine merge upstream

@kpollich
Copy link
Member Author

kpollich commented Jul 19, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Jul 19, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 864.2KB 864.5KB +353.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 113.2KB 113.3KB +58.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit f862943 into elastic:main Jul 19, 2022
kibanamachine pushed a commit that referenced this pull request Jul 19, 2022
@kpollich
[Fleet] Fleet Server flyout fixes (#136566)
76f195c 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2022
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 19, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@kpollich kpollich deleted the 2022-07-18-fleet-server-flyout-fixes branch July 19, 2022 18:45
kibanamachine added a commit that referenced this pull request Jul 19, 2022
@kibanamachine @kpollich
[Fleet] Fleet Server flyout fixes (#136566) (#136669)
4741a65 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@kpollich kpollich

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.3 v8.4.0

Projects

None yet

Milestone

No milestone

6 participants

@kpollich @elasticmachine @nchaulet @kibana-ci @kibanamachine @jen-huang