[APM] Breadcrumbs not updating from service jump on service map #136144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
reviewed
Jul 11, 2022
x-pack/plugins/apm/public/context/breadcrumbs/use_breadcrumb.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Jul 12, 2022
cauemarcondes
commented
Jul 13, 2022
x-pack/plugins/apm/public/context/breadcrumbs/use_breadcrumb.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Jul 14, 2022
x-pack/plugins/apm/public/context/breadcrumbs/use_breadcrumb.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Jul 19, 2022
| }), | ||
| }, | ||
| ], | ||
| [] |
Member
There was a problem hiding this comment.
This isn't correct - apmRouter and all the query parameters should be defined as dependencies. If you add useBreadcrumb to .eslintrc.js as suggested earlier you should see errors here too.
Contributor
Author
There was a problem hiding this comment.
My bad, forgot to update the file you mentioned. Done it here: da85a74
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dgieselaar
approved these changes
Jul 19, 2022
Member
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
Thanks! I'm pretty confident we can trust the hook now 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #133503
breadcrumb.fix.mov