Add an example of uiSettings override#135385
Merged
matschaffer merged 5 commits intomainfrom Jun 30, 2022
Merged
Conversation
matschaffer
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
2 tasks
kertal
reviewed
Jun 29, 2022
kertal
reviewed
Jun 29, 2022
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
lukeelmers
approved these changes
Jun 29, 2022
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM! Couple of minor nits/ideas, take 'em or leave 'em.
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
matschaffer
commented
Jun 30, 2022
Contributor
Author
|
@lukeelmers 's recommended setting works nice too. Merging! |
yakhinvadim
pushed a commit
to yakhinvadim/kibana
that referenced
this pull request
Jul 5, 2022
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I couldn't find an email of uiSettings override, so I added one. See #135030 (comment) for context.