Removing Flex styled elements#135317
Merged
kc13greiner merged 6 commits intoelastic:mainfrom Jul 5, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the Flex styled elements around the Form Label as suggested here
I didn't see a 1px jump, so I didn't includevertical-align: text-top;styling on the icon, but please let me know if you still see the jump and we can discuss.UPDATE: After syncing with Oleg, Im now able to see the 1px jump.
vertical-align: text-top;doesn't appear to fix the issue (locally), @MichaelMarcialis Do you have any suggestions on what we could try next?