Skip to content

Changing left and right padding on User Profiles screen#134944

Merged
kc13greiner merged 6 commits intoelastic:mainfrom
kc13greiner:feature/add_padding_to_user_profiles
Jun 28, 2022
Merged

Changing left and right padding on User Profiles screen#134944
kc13greiner merged 6 commits intoelastic:mainfrom
kc13greiner:feature/add_padding_to_user_profiles

Conversation

@kc13greiner
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner commented Jun 22, 2022 •
edited
Loading

Summary

A change was requested here to update the padding on the left/right side of the User Profile screen. The custom padding has now been removed and the screen will use the EUI defaults.

Before:
Screen Shot 2022-06-22 at 3 34 56 PM

After:
Screen Shot 2022-06-22 at 3 51 05 PM

@kc13greiner kc13greiner added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes labels Jun 22, 2022
@kc13greiner kc13greiner marked this pull request as ready for review June 22, 2022 19:53
@kc13greiner kc13greiner requested a review from a team as a code owner June 22, 2022 19:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 22, 2022

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from MichaelMarcialis June 22, 2022 19:55
@legrego legrego added the v8.4.0 label Jun 22, 2022
@legrego legrego mentioned this pull request Jun 27, 2022
Closed
azasypkin
azasypkin approved these changes Jun 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

MichaelMarcialis
MichaelMarcialis approved these changes Jun 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @kc13greiner. I've left you one last suggestion below. Otherwise, assuming that gets addressed, this looks good to me. Approving now so I don't hold you up further.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 28, 2022

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 99.1KB 99.0KB -157.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kc13greiner kc13greiner merged commit c5ce935 into elastic:main Jun 28, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 28, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
@kc13greiner kc13greiner deleted the feature/add_padding_to_user_profiles branch October 19, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azasypkin azasypkin azasypkin approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

+1 more reviewer

@cchaos cchaos cchaos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kc13greiner @elasticmachine @kibana-ci @cchaos @azasypkin @MichaelMarcialis @tylersmalley @legrego @kibanamachine