[Cloud Posture] Using Eui theme with eui charts#134759
Merged
JordanSh merged 4 commits intoelastic:mainfrom Jun 21, 2022
Merged
[Cloud Posture] Using Eui theme with eui charts#134759JordanSh merged 4 commits intoelastic:mainfrom
JordanSh merged 4 commits intoelastic:mainfrom
Conversation
JordanSh
changed the title
JordanSh
force-pushed
the
adding-theme-sync-to-charts
branch
from
f52bc18 to
4b440ea
Compare
JordanSh
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
ari-aviran
approved these changes
Jun 21, 2022
orouz
reviewed
Jun 21, 2022
| // required | ||
| data: DataPublicPluginStart; | ||
| unifiedSearch: UnifiedSearchPublicPluginStart; | ||
| charts: ChartsPluginStart; |
Contributor
Author
There was a problem hiding this comment.
as far as i saw from other usages seems like setup is not used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per #126729, we were asked to add theme syncers for our dashboard charts In order to keep
eui/chartsin sync with kibana's eui theme.It adds some minor UI changes to the page but also will help keep
eui/chartsin sync with futureeuichanges.Before
After